Skip to content

Conversation

@maxcao13
Copy link
Contributor

@maxcao13 maxcao13 commented Oct 29, 2025

Followup to #54

This commit improves the Makefile to allow more configurable build options. Also includes an EXTRA_TAG variable so automatic builds push images with branch name tags.

Related to kubernetes/test-infra#35802 because I realized we probably want to automatically push stage images based on our release branches.

Took inspiration from this Makefile: https://github.com/kubernetes-sigs/lws/blob/main/Makefile

Tested with my own repository and injected credentials:

$ gcloud builds submit --config=cloudbuild.yaml
...omitted
#17 pushing quay.io/macao/my-karpenter-test:main with docker
#17 pushing layer 8fa10c0194df 0.7s done
...omitted...
#17 DONE 0.7s

#5 [stage-1 1/3] FROM gcr.io/distroless/static:nonroot-amd64@sha256:127eb3c971acb50a3c7b511a978bb497b56add4c91225e57605b3b43cc0a9662
PUSH
DONE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ID                                    CREATE_TIME                DURATION  SOURCE                                                                                        IMAGES  STATUS
d4885e4a-0c40-468c-a142-d676a88b3191  2025-10-29T20:41:50+00:00  5M40S     gs://default-476521_cloudbuild/source/1761770498.694338-c5c121acf11b415ca19d198fb59c3088.tgz  -       SUCCESS

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2025
@maxcao13
Copy link
Contributor Author

maxcao13 commented Oct 29, 2025

@ttsuuubasa Idk if anyone is relying on the old existing Makefile variables, but since this repo is in alpha stage I think we can make changes like this, but just giving a heads up.

/cc @elmiko

This commit improves the Makefile to allow more configurable build options.
Also includes an EXTRA_TAG variable so automatic builds push images with branch name tags

Signed-off-by: Max Cao <[email protected]>
Copy link
Collaborator

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

/hold

this looks fine to me, feel free to unhold if you are ok @maxcao13

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@maxcao13
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit fd62ced into kubernetes-sigs:main Oct 30, 2025
4 checks passed
@maxcao13 maxcao13 deleted the fix-cloudbuild branch October 30, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants