-
Notifications
You must be signed in to change notification settings - Fork 24
Fix cloudbuild to include an extra tag #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ttsuuubasa Idk if anyone is relying on the old existing Makefile variables, but since this repo is in alpha stage I think we can make changes like this, but just giving a heads up. /cc @elmiko |
This commit improves the Makefile to allow more configurable build options. Also includes an EXTRA_TAG variable so automatic builds push images with branch name tags Signed-off-by: Max Cao <[email protected]>
915a741 to
5e3df9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Followup to #54
This commit improves the
Makefileto allow more configurable build options. Also includes an EXTRA_TAG variable so automatic builds push images with branch name tags.Related to kubernetes/test-infra#35802 because I realized we probably want to automatically push stage images based on our release branches.
Took inspiration from this
Makefile: https://github.com/kubernetes-sigs/lws/blob/main/MakefileTested with my own repository and injected credentials: