Skip to content

Conversation

@maxcao13
Copy link
Contributor

@maxcao13 maxcao13 commented Oct 31, 2025

Fixes #N/A

Description
Ran make generate.
The crds are out of date with our version of upstream karpenter core.
I also had to change a line in the generate make target, because otherwise it autogenerated a test crd.

In the future, we should run make generate whenever bumping Karpenter.

I want to followup this PR with one that allows the helm chart to copy over these autogenerated crds.

Note that v1beta versions got removed from the NodePool and NodeClaim crds.

How was this change tested?
Tested by running manually with new crds applied and this no longer gets logged:

{"level":"INFO","time":"2025-10-31T19:27:14.289Z","logger":"controller","message":"unknown field \"status.nodeClassObservedGeneration\"","controller":"nodepool.registrationhealth","controllerGroup":"karpenter.sh","controllerKind":"NodePool","NodePool":{"name":"default"},"namespace":"","name":"default","reconcileID":"32e9e751-bb5e-4f7d-997d-690f6946ed6c"}

And scale-up and scale-down works as before.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2025
@elmiko
Copy link
Collaborator

elmiko commented Oct 31, 2025

In the future, we should run make generate whenever bumping Karpenter.

I want to followup this PR with one that allows the helm chart to copy over these autogenerated crds.

sounds good to me Max

@elmiko
Copy link
Collaborator

elmiko commented Oct 31, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 298c1ad into kubernetes-sigs:main Oct 31, 2025
4 checks passed
@maxcao13 maxcao13 deleted the update-crd branch October 31, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants