CA: Update Azure SDK to v2 #8784
Open
+2,244
−1,006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/cluster-autoscaler
size/XXL
Contributor
Author
|
/cc @jackfrancis |
Contributor
Author
|
/cc @nojnhuh |
mboersma
force-pushed
the
azure-sdk-v2
branch
from
e3ba9bb to
7047504
Compare
jackfrancis
approved these changes
Nov 10, 2025
Contributor
jackfrancis
left a comment
jackfrancis
left a comment
There was a problem hiding this comment.
/lgtm
/hold for review from @tallaxes
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/release-note-edit |
k8s-ci-robot
added
release-note
mboersma
commented
Nov 10, 2025
|
|
||
| klog "k8s.io/klog/v2" | ||
|
|
||
| "sigs.k8s.io/cloud-provider-azure/pkg/azureclients/deploymentclient" |
Contributor
Author
There was a problem hiding this comment.
The Azure code was using these client interfaces exported by cloud-provider-azure, but they didn't support Azure SDK v2 and have been removed in current releases.
mboersma
commented
Nov 10, 2025
| github.com/Azure/azure-sdk-for-go/sdk/azcore v1.20.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.13.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v7 v7.1.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerservice/armcontainerservice/v5 v5.1.0-beta.2 |
Contributor
Author
mboersma
commented
Nov 10, 2025
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v7 v7.1.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerservice/armcontainerservice/v5 v5.1.0-beta.2 | ||
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v7 v7.1.0 | ||
| github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources/v2 v2.1.0 |
Contributor
Author
There was a problem hiding this comment.
The current API version for armresources is v3, but it has some breaking changes and seems to lack DeploymentExtended, so I went with the previous version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/area provider/azure
What this PR does / why we need it:
Updates the Azure cluster-autoscaler backend to use Azure SDK v2.
Which issue(s) this PR fixes:
Fixes #8145
Special notes for your reviewer:
Does this PR introduce a user-facing change?