-
Notifications
You must be signed in to change notification settings - Fork 244
fix bazel build with python dependency #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YifeiZhuang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c1c091c to
db6fff9
Compare
|
/test cloud-provider-gcp-tests |
|
cc. @XuanWang-Amos |
|
lgtm though I agree with the comment on changing the name to python_3_9 or similar to match the version. We've been debating just deleting the bazel, I don't think there is test coverage (hence why the build is broken, perhaps!). Any thoughts? |
Fixed name. There are test coverages, prow presubmit, just the failure does not happen on the prow machine, nor on my mac, only on my linux machine. It sounds we should move to Make. But there are certain cleanups we need to do that are still referring to bazel, e2e, readme, etc. |
Fix
bazel build //release:release-tarsbuild error. It looks bazel is confused about the python version.This problem is probably linux environment only(not exist in the CI machine or mac).
This is error log from my glinux machine: