Skip to content

Conversation

@minikube-bot
Copy link
Collaborator

The cni-plugins project released a new version

This PR was auto-generated by make update-cni-plugins-version using update-cni-plugins-version.yml CI Workflow.

@minikube-bot
Copy link
Collaborator Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2025
@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@medyagh
Copy link
Member

medyagh commented Nov 18, 2025

clean up duplicates

@medyagh medyagh closed this Nov 18, 2025
@prezha
Copy link
Contributor

prezha commented Nov 19, 2025

reopening as this is a follow up, "proper", pr after fixing the update framework in #21902

@prezha prezha reopened this Nov 19, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025
@prezha
Copy link
Contributor

prezha commented Nov 19, 2025

ok-to-build-image

@prezha
Copy link
Contributor

prezha commented Nov 19, 2025

ok-to-build-iso

@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, building a new kicbase image failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/21918/24ea1c3/kic_image_build.txt

@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2025
@prezha
Copy link
Contributor

prezha commented Nov 19, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2025
@minikube-pr-bot

This comment has been minimized.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot
Copy link
Contributor

@minikube-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-kvm-docker-linux-x86-64 08454a1 link true /test integration-kvm-docker-linux-x86-64
integration-docker-docker-linux-x86-64 08454a1 link true /test integration-docker-docker-linux-x86-64
integration-kvm-containerd-linux-x86-64 08454a1 link true /test integration-kvm-containerd-linux-x86-64
pull-minikube-build 08454a1 link true /test pull-minikube-build
integration-docker-crio-linux-x86-64 08454a1 link true /test integration-docker-crio-linux-x86-64
integration-kvm-crio-linux-x86-64 08454a1 link true /test integration-kvm-crio-linux-x86-64
integration-none-docker-linux-x86-64 08454a1 link true /test integration-none-docker-linux-x86-64
integration-docker-containerd-linux-x86-64 08454a1 link true /test integration-docker-containerd-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21918 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 42.3s    │ 41.3s                  │
│ enable ingress │ 15.4s    │ 15.8s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube (PR 21918) start: 40.4s 43.4s 43.2s 40.0s 39.3s
Times for minikube start: 40.4s 40.9s 45.0s 40.4s 44.8s

Times for minikube ingress: 15.8s 14.8s 14.8s 15.8s 15.8s
Times for minikube (PR 21918) ingress: 16.3s 15.2s 15.7s 15.7s 15.8s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21918 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.9s    │ 23.2s                  │
│ enable ingress │ 11.0s    │ 15.0s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 19.9s 22.3s 23.5s 21.2s 22.7s
Times for minikube (PR 21918) start: 21.4s 26.6s 20.8s 21.9s 25.3s

Times for minikube ingress: 10.6s 12.6s 10.6s 10.6s 10.6s
Times for minikube (PR 21918) ingress: 11.6s 10.6s 31.6s 10.6s 10.6s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21918 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.1s    │ 19.7s                  │
│ enable ingress │ 20.1s    │ 20.1s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 20.6s 20.7s 25.0s 21.0s 23.0s
Times for minikube (PR 21918) start: 20.3s 18.7s 19.3s 20.5s 19.5s

Times for minikube ingress: 20.1s 20.1s 20.1s 20.1s 20.1s
Times for minikube (PR 21918) ingress: 20.1s 20.1s 20.1s 20.1s 20.1s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Windows (1 failed) TestErrorSpam/setup(gopogh) Unknown
Docker_Linux_containerd (4 failed) TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/no-preload/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/embed-certs/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh) 2.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/embed-certs/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/no-preload/serial/DeployApp(gopogh) 0.00% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@prezha prezha closed this Nov 23, 2025
@prezha
Copy link
Contributor

prezha commented Nov 23, 2025

will use fresh pr #21975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants