Skip to content

build: bump golang manually to 1.25.3 #21934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

build: bump golang manually to 1.25.3 #21934

wants to merge 6 commits into from
+110 −102

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Nov 19, 2025 •
edited
Loading

bumps golang to 1.25
and also removes hyperkit from cross build till we decide if to remove hyperkit fully or continue allowing it #21940

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nirs November 19, 2025 21:24
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2025
@medyagh
Copy link
Member Author

medyagh commented Nov 19, 2025

/ok-to-build-image

@medyagh medyagh changed the title bump golang manually to 1.25.3 build: bump golang manually to 1.25.3 Nov 19, 2025
@medyagh
Copy link
Member Author

medyagh commented Nov 19, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 19, 2025
@minikube-bot
Copy link
Collaborator

minikube-bot commented Nov 19, 2025

Hi @medyagh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@medyagh
Copy link
Member Author

medyagh commented Nov 19, 2025

/retest-this-please

@medyagh
Copy link
Member Author

medyagh commented Nov 19, 2025

/ok-to-test

@medyagh medyagh mentioned this pull request Nov 20, 2025
Open
Copilot AI mentioned this pull request Nov 20, 2025
Closed
@medyagh
Copy link
Member Author

medyagh commented Nov 21, 2025

/ok-to-test

@medyagh
Copy link
Member Author

medyagh commented Nov 21, 2025

/retest

@medyagh
Copy link
Member Author

medyagh commented Nov 21, 2025

/retest-this-please

@medyagh
Copy link
Member Author

medyagh commented Nov 21, 2025

OK to test

@medyagh
Copy link
Member Author

medyagh commented Nov 21, 2025

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

@medyagh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-docker-containerd-linux-x86-64 0ee4f00 link true /test integration-docker-containerd-linux-x86-64
integration-docker-crio-linux-x86-64 0ee4f00 link true /test integration-docker-crio-linux-x86-64
integration-none-docker-linux-x86-64 0ee4f00 link true /test integration-none-docker-linux-x86-64
integration-kvm-containerd-linux-x86-64 0ee4f00 link true /test integration-kvm-containerd-linux-x86-64
integration-kvm-crio-linux-x86-64 0ee4f00 link true /test integration-kvm-crio-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link

minikube-pr-bot commented Nov 22, 2025

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21934 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 41.6s    │ 39.3s                  │
│ enable ingress │ 15.7s    │ 15.6s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 41.0s 38.8s 42.3s 42.5s 43.4s
Times for minikube (PR 21934) start: 39.2s 41.9s 39.7s 38.3s 37.7s

Times for minikube ingress: 15.7s 15.7s 16.7s 14.7s 15.7s
Times for minikube (PR 21934) ingress: 15.7s 15.2s 15.7s 15.7s 15.7s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21934 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.3s    │ 23.1s                  │
│ enable ingress │ 11.8s    │ 11.2s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 12.6s 10.6s 12.6s 10.6s 12.6s
Times for minikube (PR 21934) ingress: 12.6s 10.6s 10.6s 10.6s 11.6s

Times for minikube (PR 21934) start: 23.4s 23.4s 25.0s 23.6s 19.8s
Times for minikube start: 23.9s 21.5s 22.6s 21.8s 21.8s

docker driver with containerd runtime

┌───────────────────┬──────────┬────────────────────────┐
│      COMMAND      │ MINIKUBE │ MINIKUBE  ( PR 21934 ) │
├───────────────────┼──────────┼────────────────────────┤
│ minikube start    │ 21.5s    │ 20.5s                  │
│ ⚠️  enable ingress │ 20.7s    │ 26.9s ⚠️                │
└───────────────────┴──────────┴────────────────────────┘

Times for minikube start: 20.7s 23.8s 19.1s 23.4s 20.6s
Times for minikube (PR 21934) start: 19.6s 19.2s 21.7s 22.5s 19.5s

Times for minikube (PR 21934) ingress: 20.1s 22.1s 21.1s 50.1s 21.1s
Times for minikube ingress: 22.1s 20.1s 21.1s 20.1s 20.1s

@minikube-pr-bot
Copy link

minikube-pr-bot commented Nov 22, 2025

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_containerd (4 failed) TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/no-preload/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/embed-certs/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd (4 failed) TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh) 2.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/old-k8s-version/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/default-k8s-diff-port/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/embed-certs/serial/DeployApp(gopogh) 0.00% (chart)
Docker_Linux_containerd_arm64 (4 failed) TestStartStop/group/no-preload/serial/DeployApp(gopogh) 0.00% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@medyagh medyagh closed this Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@nirs nirs Awaiting requested review from nirs

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@medyagh @k8s-ci-robot @minikube-bot @minikube-pr-bot