fix kops job generator #35878
Open
fix kops job generator #35878
+108,048
−7,979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/cluster-lifecycle
upodroid
force-pushed
the
kops-job-fixes
branch
3 times, most recently
from
756053d to
60d3be2
Compare
justinsb
reviewed
Nov 6, 2025
| for k8s_version in k8s_versions: | ||
| for kops_version in [None]: # TODO: all kops_versions: | ||
| for kops_version in kops_versions: | ||
| distro_short = distro.replace('ubuntu', 'u').replace('debian', 'deb').replace('amazonlinux', 'amzn') |
Member
There was a problem hiding this comment.
I assume this is because we get names that are too long otherwise (for use as cluster names?)
Member
Author
There was a problem hiding this comment.
Yes, it's currently like that for the AWS jobs.
upodroid
force-pushed
the
kops-job-fixes
branch
from
60d3be2 to
2481798
Compare
ameukam
reviewed
Nov 8, 2025
| def generate_misc(): | ||
| results = [ | ||
| # A one-off scenario testing the k8s.gcr.io mirror | ||
| build_test(name_override="kops-scenario-gcr-mirror", |
Member
There was a problem hiding this comment.
Let's keep this test. The failure here is intentional. The comment is misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Busy PR, but it does the following:
I'll fix up the upgrade jobs in a separate PR