Skip to content

Conversation

@vedansh-5
Copy link
Collaborator

📝 Summary of Changes

As Mike pointed out in the meeting that we want something that would show the active selection. This PR intends to implement the same.


Changes Made

  • Updated ...
  • Refactored ...
  • Fixed ...
  • Added tests for ...

Checklist

Please ensure the following before submitting your PR:

  • I have reviewed the project's contribution guidelines.
  • I have written unit tests for the changes (if applicable).
  • I have updated the documentation (if applicable).
  • I have tested the changes locally and ensured they work as expected.
  • My code follows the project's coding standards.

Screenshots or Logs (if applicable)

image

👀 Reviewer Notes

Add any special notes for the reviewer here

Signed-off-by: Vedansh Saini <[email protected]>
Signed-off-by: Vedansh Saini <[email protected]>
@SakshamDutt
Copy link
Collaborator

@vedansh-5 If we are showing active selection for the playground and marketplace, then we should also implement something for other pages, like installation, contribute handbook.

@vedansh-5
Copy link
Collaborator Author

@naman9271 @oksaumya This PR adds the active glow that Mike suggested in scrum meet.
Its a WIP, I have added glow only in the first three sections and not in contribute and community. I'll add it in those as soon as I have the confirmation on two things:
1> Do we need this?
2> Is the glow okay? I think underlining would be more minimalistic and significant here. @KPRoche
Thanks!

@vedansh-5
Copy link
Collaborator Author

@naman9271 @oksaumya This PR adds the active glow that Mike suggested in scrum meet. Its a WIP, I have added glow only in the first three sections and not in contribute and community. I'll add it in those as soon as I have the confirmation on two things: 1> Do we need this? 2> Is the glow okay? I think underlining would be more minimalistic and significant here. @KPRoche Thanks!

waiting for your review folks, please answer whenever you have some time. @naman9271 @oksaumya @KPRoche

@naman9271
Copy link
Member

@naman9271 @oksaumya This PR adds the active glow that Mike suggested in scrum meet. Its a WIP, I have added glow only in the first three sections and not in contribute and community. I'll add it in those as soon as I have the confirmation on two things: 1> Do we need this? 2> Is the glow okay? I think underlining would be more minimalistic and significant here. @KPRoche Thanks!

waiting for your review folks, please answer whenever you have some time. @naman9271 @oksaumya @KPRoche

Sorry @vedansh-5 quite a busy this week,

yes we can add this and to make consistemcy i think it is better to add this in dropdowns also contribute community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants