MTV-3443: MTV template methods #796
Merged
+170
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardHoch
force-pushed
the
MTV-3443_mtv_template_methods
branch
from
5c2f1ea to
f4d7a08
Compare
vashirova
approved these changes
Nov 18, 2025
vashirova
left a comment
vashirova
left a comment
There was a problem hiding this comment.
@RichardHoch peer review completed, I left my suggestions (mostly for the tables). Overall brilliant work, thank you for the opportunity!
RichardHoch
force-pushed
the
MTV-3443_mtv_template_methods
branch
3 times, most recently
from
6f19039 to
fd79c26
Compare
RichardHoch
force-pushed
the
MTV-3443_mtv_template_methods
branch
from
fd79c26 to
79a6b18
Compare
mnecas
approved these changes
Nov 27, 2025
RichardHoch
force-pushed
the
MTV-3443_mtv_template_methods
branch
from
79a6b18 to
13f8e74
Compare
AmenB
reviewed
Dec 1, 2025
| *** Click the {kebab} of the VM. | ||
| *** Select *Edit Volume name template*. | ||
| *** Enter the template according to the instructions. | ||
| *** Enter the template according to the instructions. Be sure that your template does not generate VM names that include uppercase letters. |
There was a problem hiding this comment.
I think it not only needs to use uppercase letters, but it also needs to adhere to k8s formatting
@mnecas, what do you think?
Member
There was a problem hiding this comment.
yeah that's true, it should follow rfc1123
Collaborator
Author
There was a problem hiding this comment.
RichardHoch
force-pushed
the
MTV-3443_mtv_template_methods
branch
from
13f8e74 to
c18193c
Compare
|
LGTM |
Signed-off-by: Richard Hoch <[email protected]>
RichardHoch
force-pushed
the
MTV-3443_mtv_template_methods
branch
from
2402809 to
cb6b092
Compare
mnecas
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTV 2.10.1
Resolves https://issues.redhat.com/browse/MTV-3443 by:
Previews:
https://file.corp.redhat.com/rhoch/MTV-3443_mtv_template_methods_mig/html-single/#mtv-template-utility_vmware
https://file.corp.redhat.com/rhoch/MTV-3443_mtv_template_methods_plan/html-single/#creating-plan-wizard-vmware_vmware [note at end of step 23, part c]
https://file.corp.redhat.com/rhoch/MTV-3443_mtv_template_methods_mig/html-single/#proc_migrating-virtual-machines-cli_vmware [Step 8, note following callout 9]