CI: Reduce the min GCC version used to match what MakeCode (PXT) uses. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including stdio.h before MicroBit.h caused a stdio macro for putc(int, FILE*) to cause havoc on putc methods in multiple CODAL classes like serial.
microbit-carlos
commented
Jan 20, 2025
Collaborator
Author
microbit-carlos
left a comment
microbit-carlos
left a comment
There was a problem hiding this comment.
CI passes and this change is needed to apply the same patch into the codal-microbit-v2 CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also fixes an issue building with GCC v6 when stdio.h is included before MicroBit.h
This is because stdio packed in arm-none-eabi-gcc (probably newlibc? can't remember when they changed the default) seems to have macro for
putc(int, FILE*)to cause havoc onputcmethods in multiple CODAL classes like serial.This issue was not triggered in the pxt-microbit builds using
pext/yotta:lattestbecause the include line is in one of the file included in this repo, which pxt-microbit doesn't build.