fix: Store vectors as binary for FT index compatibility ValkeyStore #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style(valkey): Fix formatting and remove duplicate imports - Use double quotes consistently for f-strings - Remove duplicate asyncio and struct imports - Format multi-line function calls on single line per ruff
3coins
reviewed
Nov 25, 2025
libs/langgraph-checkpoint-aws/tests/unit_tests/store/valkey/test_valkey_index_config_unit.py
Outdated
Show resolved
Hide resolved
3coins
reviewed
Nov 25, 2025
libs/langgraph-checkpoint-aws/langgraph_checkpoint_aws/store/valkey/search_strategies.py
Outdated
Show resolved
Hide resolved
3coins
reviewed
Dec 1, 2025
libs/langgraph-checkpoint-aws/langgraph_checkpoint_aws/store/valkey/search_strategies.py
Outdated
Show resolved
Hide resolved
3coins
reviewed
Dec 1, 2025
libs/langgraph-checkpoint-aws/langgraph_checkpoint_aws/store/valkey/async_store.py
Outdated
Show resolved
Hide resolved
3coins
approved these changes
Dec 6, 2025
Collaborator
3coins
left a comment
3coins
left a comment
There was a problem hiding this comment.
@seaofawareness
Thanks for making all the updates. Approving to move this forward as there are no API changes, but feel that the adapter approach is an overkill for handling combination of embeddings and store with async/sync methods in sync/async contexts. It is unusual for users to have these misconfigured, and a simpler approach would be preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store vectors as binary for FT index compatibility ValkeyStore