Feat/new trainer and admin deletion queries #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
force-pushed
the
feat/new-trainer-and-admin-deletion-queries
branch
from
5578f3e to
7670583
Compare
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
force-pushed
the
feat/new-trainer-and-admin-deletion-queries
branch
from
7670583 to
e43820d
Compare
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
force-pushed
the
feat/new-trainer-and-admin-deletion-queries
branch
from
e43820d to
50eccff
Compare
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
force-pushed
the
feat/new-trainer-and-admin-deletion-queries
branch
from
50eccff to
73e4cc5
Compare
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
force-pushed
the
feat/new-trainer-and-admin-deletion-queries
branch
from
73e4cc5 to
93e927f
Compare
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
force-pushed
the
feat/new-trainer-and-admin-deletion-queries
branch
from
93e927f to
128de46
Compare
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
force-pushed
the
feat/new-trainer-and-admin-deletion-queries
branch
4 times, most recently
from
6e32da8 to
d850cf5
Compare
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
thegreenmilecomposer
force-pushed
the
feat/new-trainer-and-admin-deletion-queries
branch
from
d850cf5 to
837feb4
Compare
thegreenmilecomposer
temporarily deployed
to
staging
GitHub Actions
Inactive
alexander-schefe
requested changes
Nov 19, 2025
Contributor
alexander-schefe
left a comment
alexander-schefe
left a comment
There was a problem hiding this comment.
Not a full review, just some comments:
- should probably rename "trainerUnMarkUserForDeletion" to something like "trainerUnmarkTraineeForDeletion" as Trainers can only delete Trainees.
- Also "Unmark" is one word and shouldn't be spelled "UnMark". This is very inconsistent here, i saw some instances of "adminUnMarkUserForDeletion" with the same spelling error in my quick glance over the code as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.