Removed Path-browerify and process packages #7134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SplinterSword <[email protected]>
Contributor
|
🚀 Preview for commit 1abde69 at: https://691af56896bab295726c7484--layer5.netlify.app |
Contributor
|
@SplinterSword thanks, I tested it and it is working. lgtm |
Contributor
|
🚀 Preview for commit 6083138 at: https://691b4274aa51102d9d79711e--layer5.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6869
Notes for Reviewers
I have removed the Path-browerify and process npm packages as they were used as fallbacks for old browsers, but now modern browsers don't need these polyfills anymore making the fallback and npm packages redundant.
I was told that my changes broke the local build, I have now also checked the github pages deployment and local development server and I couldn't find any problems with it.
If someone can help me find the actual issues they face, I will make the necessary changes.
Signed commits