Skip to content

Conversation

@alreadydone
Copy link
Contributor


Open in Gitpod

@alreadydone alreadydone added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) bench-after-CI Once the PR passes CI, comment `!bench` on the PR labels Nov 21, 2025
@github-actions
Copy link

PR summary cf85478f35

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@leanprover-community-mathlib4-bot
Copy link
Collaborator

!bench

@github-actions github-actions bot removed the awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. label Nov 21, 2025
@leanprover-radar
Copy link

leanprover-radar commented Nov 21, 2025

Benchmark results for f33bfb5 against cf85478 are in! @kckennylau @leanprover-community-mathlib4-bot

@alreadydone alreadydone removed the easy < 20s of review time. See the lifecycle page for guidelines. label Nov 21, 2025
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit f33bfb5.
There were no significant changes against commit cf85478.

@github-actions
Copy link

File Instructions %
build -17.303⬝10⁹ (-0.01%)
lint +1.345⬝10⁹ (+0.02%)
Mathlib.CategoryTheory.Comma.Over.Pullback +1.86⬝10⁹ (+2.96%)
4 files, Instructions -2.0⬝10⁹
File Instructions %
Mathlib.Data.Finset.Filter -1.117⬝10⁹ (-11.21%)
Mathlib.Data.List.InsertIdx -1.126⬝10⁹ (-15.22%)
Mathlib.Order.Filter.Map -1.167⬝10⁹ (-3.40%)
Mathlib.CategoryTheory.Limits.Cones -1.621⬝10⁹ (-1.67%)

CI run Lakeprof report

@github-actions github-actions bot removed the bench-after-CI Once the PR passes CI, comment `!bench` on the PR label Nov 21, 2025
@alreadydone alreadydone added the easy < 20s of review time. See the lifecycle page for guidelines. label Nov 22, 2025
@ocfnash
Copy link
Contributor

ocfnash commented Nov 22, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Nov 22, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Algebra): make invertibleInv an instance [Merged by Bors] - chore(Algebra): make invertibleInv an instance Nov 22, 2025
@mathlib-bors mathlib-bors bot closed this Nov 22, 2025
@alreadydone alreadydone deleted the invertibleInv branch November 22, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants