Run a webserver #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runs a simple webserver to host the demonstration certificates. Right now, there's a placeholder which loads a key pair from files. This is going to be deleted in an upcoming PR, but is enough to get started without making this PR too big. The page content is also a plain text message, pending adding a better page content to be rendered.
I don't think it's always necessary to wrap errors, so this linter is not helpful. We should evaluate on a case-by-case basis when wrapping is helpful. Fix unused parameter warning on the todoGetCert placeholder function.
aarongable
approved these changes
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs a simple webserver to host the demonstration certificates.
Right now, there's a placeholder which loads a key pair from files. This is going to be deleted in an upcoming PR, but is enough to get started without making this PR too big.
The page content is also a plain text message, pending adding a better page content to be rendered.
This PR disables the wrapcheck linter because I think it's not always helpful, and we should consider on a case-by-case basis on when wrapping errors is useful. They're not stack traces.