Add certificate storage #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is code to store keys and certificates on disk. The general way I expect this to be used is outlined in the test: A user generates a key, goes off to a CA for a cert, and stores it as the "next" certificate. Once it is verified to be "good" for whatever definition that means to the caller, they can copy it to the current key. The goal here is to abstract the disk format away from the user, but it uses PEM for both PKCS8 keys and certificates to make it easy to use the files in an external program if required (eg, openssl x509 -text ...)
I thought about doing this but realized it wasn't really needed. Loading checks that they match, so there's no need to eagerly remove certs.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a certificate storage system that manages TLS certificates and private keys on disk using a structured directory layout with "current" and "next" versions for safe certificate rotation.
Key changes:
- Implements a certificate lifecycle management system with "next" staging and "current" production versions
- Provides key generation for P256 ECDSA and RSA 2048-bit keys stored in PKCS8 PEM format
- Includes comprehensive test coverage demonstrating the full certificate rotation workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| storage/storage.go | Core implementation of certificate storage with key generation, certificate staging, and rotation functionality |
| storage/storage_test.go | Test suite validating the complete certificate lifecycle including key generation, storage, and rotation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jsha
requested changes
Sep 29, 2025
Using a crypto.Signer makes the tests a bit cleaner, and is what is actually needed to use the key.
This uses constants for next/current, making API call sites more readable. TakeNext now returns the now-current values, which also adds an extra level of protection that the next key and certificate match
jsha
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is code to store keys and certificates on disk.
The general way I expect this to be used is outlined in the test:
A user generates a key, goes off to a CA for a cert, and stores it as the "next" certificate. Once it is verified to be "good" for whatever definition that means to the caller, they can copy it to the current key.
The goal here is to abstract the disk format away from the user, but it uses PEM for both PKCS8 keys and certificates to make it easy to use the files in an external program if required (eg, openssl x509 -text ...)