Add ratelimiting errors for draw offers #18682
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API was returning a truthy value when repeated draw values were being made, meaning that it looks like the API accepted the draw when sending an invalid draw offer. We fix this by adding an error to prevent multiple draw errors within 10 moves. refs: lichess-org#17913
Collaborator
|
Have you run your code? Checked that it fixes the issue? |
Contributor
Author
|
No local test setup currently, though the fix is pretty simple. Previously the API was returning true for all cases outside of those already handled (threefold repetition, insufficent material). Now it checks to see if the player has offered a draw recently and blocks repeated attempts, and otherwise assumes the draw failed to be sent. |
Collaborator
|
Please mention that you didn't try it, and keep the PR as a draft until you have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API was returning a truthy value when repeated draw values were being made, meaning that it looks like the API accepted the draw when sending an invalid draw offer.
We fix this by adding an error to prevent multiple draw errors within 10 moves.
Fixes #17913