Skip to content

Conversation

@justforlxz
Copy link
Member

@justforlxz justforlxz commented Jul 10, 2025

Summary by Sourcery

Introduce a GlobalShortcut class in the Treeland input module to manage application-wide keyboard shortcuts mapping QActions to key sequences.

New Features:

  • Add GlobalShortcut class with methods to set, retrieve, check, and remove shortcuts for QActions.

Build:

  • Include globalshortcut.h and globalshortcut.cpp in the CMakeLists for the input module.

@deepin-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 10, 2025

Reviewer's Guide

This PR adds a new GlobalShortcut component (with public and private classes) for managing QAction-to-key-sequence mappings using the d-pointer pattern, and updates the build configuration to include these new source files.

File-Level Changes

Change Details Files
Introduced GlobalShortcut component to manage application-wide keyboard shortcuts
  • Added GlobalShortcut and GlobalShortcutPrivate classes using Q_DECLARE_PRIVATE/Q_DECLARE_PUBLIC
  • Implemented setShortcut, shortcut, hasShortcut and removeAllShortcuts API methods
  • Stored QAction-to-QKeySequence mappings in a QHash
  • Initialized private data in the constructor via an init stub
src/input/globalshortcut.h
src/input/globalshortcut.cpp
Updated CMakeLists to include new shortcut source files
  • Added globalshortcut.h and globalshortcut.cpp to the qt_add_qml_module sources list
src/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-bot
Copy link

deepin-bot bot commented Jul 31, 2025

TAG Bot

New tag: 0.6.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #477

@deepin-bot
Copy link

deepin-bot bot commented Aug 1, 2025

TAG Bot

New tag: 0.6.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #482

@deepin-bot
Copy link

deepin-bot bot commented Aug 4, 2025

TAG Bot

New tag: 0.6.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #486

@deepin-bot
Copy link

deepin-bot bot commented Aug 29, 2025

TAG Bot

New tag: 0.7.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #540

@deepin-bot
Copy link

deepin-bot bot commented Sep 18, 2025

TAG Bot

New tag: 0.7.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #560

@deepin-bot
Copy link

deepin-bot bot commented Sep 19, 2025

TAG Bot

New tag: 0.7.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #562

@deepin-bot
Copy link

deepin-bot bot commented Sep 23, 2025

TAG Bot

New tag: 0.7.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #569

@deepin-bot
Copy link

deepin-bot bot commented Oct 30, 2025

TAG Bot

New tag: 0.7.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #611

@deepin-bot
Copy link

deepin-bot bot commented Nov 7, 2025

TAG Bot

New tag: 0.7.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #619

@deepin-bot
Copy link

deepin-bot bot commented Nov 14, 2025

TAG Bot

New tag: 0.7.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants