Skip to content

Conversation

@mtwebster
Copy link
Member

@mtwebster mtwebster requested a review from Copilot April 15, 2025 19:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 18 out of 23 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • debian/cinnamon-settings-daemon.install: Language not supported
  • debian/control: Language not supported
  • debian/rules: Language not supported
  • meson.build: Language not supported
  • plugins/keyboard/meson.build: Language not supported
Comments suppressed due to low confidence (4)

plugins/settings-remap/csd-settings-remap-manager.c:63

  • Verify that the removal of the a11y and input-sources schema mappings is intentional and that any dependent functionality is updated accordingly.
-    { "org.gnome.desktop.a11y", "org.cinnamon.desktop.a11y.keyboard" },

plugins/keyboard/main.c:12

  • Confirm that removing the forced X11 backend definition does not negatively impact environments that may rely on it.
-// This plugin must run under x11/xwayland

plugins/keyboard/csd-keyboard-manager.h:38

  • The include guard has been changed to __GSD_KEYBOARD_MANAGER_H which does not match the file name; please update it to __CSD_KEYBOARD_MANAGER_H if that was intended.
+#endif /* __GSD_KEYBOARD_MANAGER_H */

plugins/a11y-settings/csd-a11y-settings-manager.c:189

  • Ensure that the removal of the binding for 'screen-keyboard-enabled' is intentional and that its functionality is either no longer required or handled elsewhere.
-    bind_keys (manager, CINNAMON_A11Y_APP_SCHEMA, "screen-keyboard-enabled", GNOME_A11Y_APP_SCHEMA, "screen-keyboard-enabled");

@mtwebster mtwebster force-pushed the modernize-kb-layouts branch from 802fa0c to 79219ca Compare May 21, 2025 12:56
@clefebvre clefebvre merged commit 0022537 into master Sep 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants