[circt-verilog] Move pipeline into ImportVerilog. #9208
Conversation
SimonEbner
force-pushed
the
circt-verilog-pipeline
branch
2 times, most recently
from
f231527 to
7c48b5e
Compare
SimonEbner
changed the title
SimonEbner
force-pushed
the
circt-verilog-pipeline
branch
4 times, most recently
from
a25df3d to
f97b81c
Compare
jpienaar
left a comment
jpienaar
left a comment
There was a problem hiding this comment.
It would be nice to be able to reuse this - much less guess work and enables mixing and matching in pass pipeline.
| const ImportVerilogOptions *options = nullptr); | ||
|
|
||
| /// Optimize and simplify the Moore dialect IR. | ||
| void verilogToMoorePipeline(mlir::PassManager &pm); |
There was a problem hiding this comment.
Could we just forward declare PassManager too?
There was a problem hiding this comment.
Good point, done.
| /// command line options. | ||
| static void populatePasses(PassManager &pm) { | ||
| populateMooreTransforms(pm); | ||
| verilogToMoorePipeline(pm); |
There was a problem hiding this comment.
Is the main reason you made 3 instead of 1 populate method so that you could have this same split?
There was a problem hiding this comment.
Yes, basically just moved the pipelines into the lib. On one hand it seems cleaner to have the flow control outside the pipeline (opts.loweringMode). OTOH, having just one pipeline seems easier to use. No strong preference on my end, happy to coalesce the pipelines into one if preferred.
SimonEbner
force-pushed
the
circt-verilog-pipeline
branch
2 times, most recently
from
415aa14 to
3e2e27c
Compare
Break out the circt-verilog import pipeline so it can reused easily.
SimonEbner
force-pushed
the
circt-verilog-pipeline
branch
from
3e2e27c to
f0e54b7
Compare
jpienaar
left a comment
jpienaar
left a comment
There was a problem hiding this comment.
Seems good refactoring to enable reuse as library. Lets perhaps give one day if there is any objection, but seems good to me.
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
LGTM! Great idea having this factored out and reusable!
3 participants
Break out the circt-verilog import pipeline so it can reused easily.