[ESI][Runtime] Add JSON output for esiquery telemetry #9240
+52
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds JSON output capability to the esiquery telemetry command, allowing users to dump telemetry information in JSON format alongside the existing human-readable output.
Key Changes:
- Added a
--jsonflag to the telemetry subcommand - Implemented JSON serialization for telemetry data with hierarchical structure support
- Added nlohmann/json library dependency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/Dialect/ESI/runtime/cpp/tools/esiquery.cpp | Implements JSON output for telemetry with new printTelemetryJson function and helper functions for building hierarchical JSON structure |
| lib/Dialect/ESI/runtime/CMakeLists.txt | Adds nlohmann_json library dependency to esiquery target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
teqdruid
force-pushed
the
teqdruid/esiquery-json
branch
from
9c70ca7 to
ff26458
Compare
Copilot finished reviewing on behalf of
teqdruid
November 18, 2025 22:11
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.