Skip to content

Conversation

@ashermancinelli
Copy link
Contributor

Adds tests and dialects for rocdl, llvm, gpu and transform.

@ashermancinelli
Copy link
Contributor Author

@makslevental leaving an xfail for you, maybe related to your last pr

FAILED tests/dialect/test_gpu.py::test_generic_type_var_closure_patching_dependent_generics -
RuntimeError: generic A_t must have concrete val

@makslevental
Copy link
Contributor

@makslevental leaving an xfail for you, maybe related to your last pr

FAILED tests/dialect/test_gpu.py::test_generic_type_var_closure_patching_dependent_generics -
RuntimeError: generic A_t must have concrete val

change the colons (:) to = in the generics in those tests and et voila

@makslevental
Copy link
Contributor

Lemme commit on top - I have some fixes for some stuff...

@makslevental makslevental merged commit 233b970 into main Nov 18, 2025
14 checks passed
@makslevental makslevental deleted the ajm/add-xform-gpu branch November 18, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants