Skip to content

[lldb][Language] Pass SymbolNameFitsToLanguage parameter by const-ref #167684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

[lldb][Language] Pass SymbolNameFitsToLanguage parameter by const-ref #167684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lldb/include/lldb/Target/Language.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,9 @@ class Language : public PluginInterface {
///
/// This function should only return true if there is a high confidence
/// that the name actually belongs to this language.
virtual bool SymbolNameFitsToLanguage(Mangled name) const { return false; }
virtual bool SymbolNameFitsToLanguage(const Mangled &name) const {
return false;
}

/// An individual data formatter may apply to several types and cross language
/// boundaries. Each of those languages may want to customize the display of
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ CPlusPlusLanguage::GetFunctionNameInfo(ConstString name) const {
return {func_name_type, ConstString(basename)};
}

bool CPlusPlusLanguage::SymbolNameFitsToLanguage(Mangled mangled) const {
bool CPlusPlusLanguage::SymbolNameFitsToLanguage(const Mangled &mangled) const {
auto mangling_scheme =
Mangled::GetManglingScheme(mangled.GetMangledName().GetStringRef());
return mangling_scheme == Mangled::eManglingSchemeItanium ||
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class CPlusPlusLanguage : public Language {

static llvm::StringRef GetPluginNameStatic() { return "cplusplus"; }

bool SymbolNameFitsToLanguage(Mangled mangled) const override;
bool SymbolNameFitsToLanguage(const Mangled &mangled) const override;

bool DemangledNameContainsPath(llvm::StringRef path,
ConstString demangled) const override;
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ ObjCLanguage::GetFunctionNameInfo(ConstString name) const {
return {func_name_type, std::nullopt};
}

bool ObjCLanguage::SymbolNameFitsToLanguage(Mangled mangled) const {
bool ObjCLanguage::SymbolNameFitsToLanguage(const Mangled &mangled) const {
ConstString demangled_name = mangled.GetDemangledName();
if (!demangled_name)
return false;
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Language/ObjC/ObjCLanguage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ class ObjCLanguage : public Language {
std::pair<lldb::FunctionNameType, std::optional<ConstString>>
GetFunctionNameInfo(ConstString name) const override;

bool SymbolNameFitsToLanguage(Mangled mangled) const override;
bool SymbolNameFitsToLanguage(const Mangled &mangled) const override;

lldb::TypeCategoryImplSP GetFormatters() override;

Expand Down
Loading