Fix: Use yaml.Unmarshal instead of UnmarshalStrict for config compatibility #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility This change allows the hostpath-mapper to work with newer vCluster configurations that might contain fields not defined in the current Config struct. Previously, when using UnmarshalStrict, the mapper would fail with an error like: 'error unmarshaling JSON: while decoding JSON: json: unknown field "reuseNamespace"' Using regular Unmarshal provides forward compatibility with future configuration options.
|
I hit this as well with vcluster 0.23.0 and hpm 0.2.0 loft-sh/vcluster#1745 (comment) |
|
Thanks @Marouan-chak! @neogopher if you'd like to comment here, I believe what we want to do is update the |
Contributor
|
That's correct @zerbitx. @m-chakran @hellt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the unmarshal method from
yaml.UnmarshalStricttoyaml.Unmarshalin the hostpaths.go file to allow forward compatibility with newer vCluster configurations.Problem
When running the hostpath-mapper with newer vCluster configurations that include fields not yet defined in the current Config struct (like "reuseNamespace"), the application fails with an error:
Solution
By switching to
yaml.Unmarshalinstead ofyaml.UnmarshalStrict, we allow the parser to ignore fields that are not defined in the target struct, providing forward compatibility with future vCluster configuration versions.Testing
Tested by running the hostpath-mapper with a configuration that includes the "reuseNamespace" field. After this change, the application starts successfully and properly processes the configuration.