Lectures: Allow Cancellation of Transcript Requests
#11688
Conversation
github-actions
bot
added
tests
server
Anishyou
changed the title
Lectures: Allow Cancellation of Transcript Requests
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||
WalkthroughAdds a transcription cancellation feature: backend service method and DELETE endpoint to cancel Nebula jobs and remove records; frontend UI/components to confirm and invoke cancellation, loading/alert handling and template bindings; tests and i18n entries for English and German. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as Frontend Component
participant Modal as Confirm Modal
participant FESvc as LectureTranscriptionService (FE)
participant API as NebulaTranscriptionResource (REST)
participant BE as LectureTranscriptionService (BE)
participant Nebula as Nebula Service
User->>UI: Click "Cancel" button
UI->>Modal: open confirmation
alt user confirms
Modal-->>UI: confirmed
UI->>FESvc: cancelTranscription(lectureUnitId)
FESvc->>API: DELETE /lecture-unit/{id}/transcriber/cancel
API->>BE: cancelNebulaTranscription(id)
BE->>BE: validate transcription & jobId/state
BE->>Nebula: POST /transcribe/cancel/{jobId} (auth header)
Nebula-->>BE: 200 OK
BE->>BE: delete transcription record & flush
BE-->>API: 200 OK
API-->>FESvc: 200 OK
FESvc-->>UI: Observable true
UI->>UI: show success alert, update UI state
else user dismisses
Modal-->>UI: dismissed
UI->>UI: no-op
end
alt Nebula/API error
Nebula-->>BE: error (4xx/5xx) or RestClientException
BE-->>API: mapped error (4xx/5xx/500)
API-->>FESvc: error response
FESvc-->>UI: Observable false/error
UI->>UI: show error alert
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java (1)
289-292: Improve exception handling specificity.The catch block at line 289 catches all exceptions and wraps them in a 500 error. This loses information about the actual failure type. Consider catching specific exceptions (e.g.,
RestClientExceptionfor HTTP errors) to provide more precise error codes and messages.+catch (RestClientException e) { + log.error("Nebula service error cancelling transcription for lectureUnitId: {}, jobId: {} → {}", lectureUnitId, jobId, e.getMessage(), e); + throw new ResponseStatusException(HttpStatus.BAD_GATEWAY, "Failed to communicate with Nebula service: " + e.getMessage(), e); +} catch (Exception e) { log.error("Error cancelling transcription for lectureUnitId: {}, jobId: {} → {}", lectureUnitId, jobId, e.getMessage(), e); throw new ResponseStatusException(HttpStatus.INTERNAL_SERVER_ERROR, "Failed to cancel transcription: " + e.getMessage(), e); }src/test/java/de/tum/cit/aet/artemis/lecture/LectureTranscriptionServiceIntegrationTest.java (1)
248-322: Good negative coverage; consider extracting shared setup helperThe not‑found, completed, failed, and no‑job‑ID tests clearly document the expected error conditions and messages. The repeated lecture/unit + transcription setup is quite similar across these tests, so you could optionally extract a small factory/helper (e.g.
createUnitWithTranscription(status)returning both) to keep tests shorter and easier to tweak later.src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.ts (1)
385-421: Cancel flow is correct; consider sharing logic and aligning RxJS usageThe modal‑driven cancel flow,
isCancellingflag,finalizecleanup, and success/error alerts are all wired correctly and match the intended UX (only acting on confirm, bailing out when nolectureUnitId, resetting state afterward).Two optional improvements you might consider:
- This logic is almost identical to
cancelTranscription()inAttachmentVideoUnitComponent; factoring a small helper (e.g. in a shared service or a private utility that takes the unit id and aSignal<TranscriptionStatus | undefined>) would reduce duplication and keep copy‑paste bugs at bay.- If this component ever starts doing longer‑lived work in this subscription, adding
takeUntilDestroyed(with aDestroyRefinjection) would bring it in line with the rest of the codebase’s memory‑leak‑prevention pattern, although for a one‑shot HTTP call the practical risk is already very low.src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts (2)
70-77: Status loading behavior works; consider clearing stale status on reopenFetching the transcription status on each expand in
toggleCollapseand drivingshouldShowTranscriptionStatusfrom theTranscriptionStatussignal correctly enables the badge/cancel UI for PENDING/PROCESSING/FAILED.One small refinement you might consider: when opening the unit, you already reset
transcriptSegments,playlistUrl, andisLoading. ResettingtranscriptionStatusthere as well (e.g.this.transcriptionStatus.set(undefined);) would avoid briefly showing a stale status from a previous open while the newgetTranscriptionStatuscall is in flight or fails.Also applies to: 110-139
295-326: Cancel flow is correct but duplicated; consider DRY + optional RxJS cleanupThe cancel logic here cleanly mirrors the backend contract and the form component: ask for confirmation, set
isCancelling, callcancelTranscriptionon the current unit id, reset the flag viafinalize, show success/error alerts, and cleartranscriptionStatuson success so the UI updates.Two optional follow‑ups:
- The implementation is nearly identical to
AttachmentVideoUnitFormComponent.cancelTranscription(). Extracting a shared helper (or at least centralizing the alert/isCancellinghandling) would reduce maintenance overhead.- As with the form, you could add
takeUntilDestroyed(this.destroyRef)beforefinalizein the pipe to ensure the subscription is auto‑cleaned if the component is destroyed mid‑request. It’s not critical for a single HTTP call but would align with the rest of the component’s use oftakeUntilDestroyed.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java(1 hunks)src/main/java/de/tum/cit/aet/artemis/nebula/web/NebulaTranscriptionResource.java(2 hunks)src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.html(1 hunks)src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.ts(4 hunks)src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.ts(3 hunks)src/main/webapp/app/lecture/manage/lecture-units/edit-attachment-video-unit/edit-attachment-video-unit.component.html(1 hunks)src/main/webapp/app/lecture/manage/lecture-units/lecture-units.component.html(1 hunks)src/main/webapp/app/lecture/manage/services/lecture-transcription.service.spec.ts(1 hunks)src/main/webapp/app/lecture/manage/services/lecture-transcription.service.ts(1 hunks)src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.html(1 hunks)src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts(5 hunks)src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts(6 hunks)src/main/webapp/i18n/de/lectureUnit.json(1 hunks)src/main/webapp/i18n/en/lectureUnit.json(1 hunks)src/test/java/de/tum/cit/aet/artemis/lecture/LectureTranscriptionServiceIntegrationTest.java(1 hunks)src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java(3 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
src/main/java/**/*.java
⚙️ CodeRabbit configuration file
naming:CamelCase; principles:{single_responsibility,small_methods,no_duplication}; db:{perf_queries,datetime_not_timestamp}; rest:{stateless,singleton,delegate_logic,http_only,minimal_dtos}; dtos:{java_records,no_entities,min_data,single_resp}; di:constructor_injection; kiss:simple_code; file_handling:os_indep_paths; practices:{least_access,avoid_transactions,code_reuse,static_member_ref,prefer_primitives}; sql:{param_annotation,uppercase,avoid_subqueries};java:avoid_star_imports
Files:
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.javasrc/main/java/de/tum/cit/aet/artemis/nebula/web/NebulaTranscriptionResource.java
src/main/webapp/**/*.html
⚙️ CodeRabbit configuration file
@if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.
Files:
src/main/webapp/app/lecture/manage/lecture-units/lecture-units.component.htmlsrc/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.htmlsrc/main/webapp/app/lecture/manage/lecture-units/edit-attachment-video-unit/edit-attachment-video-unit.component.htmlsrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.html
src/main/webapp/**/*.ts
⚙️ CodeRabbit configuration file
Files:
src/main/webapp/app/lecture/manage/services/lecture-transcription.service.spec.tssrc/main/webapp/app/lecture/manage/services/lecture-transcription.service.tssrc/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.tssrc/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts
src/main/webapp/i18n/de/**/*.json
⚙️ CodeRabbit configuration file
German language translations should be informal (dutzen) and should never be formal (sietzen). So the user should always be addressed with "du/dein" and never with "sie/ihr".
Files:
src/main/webapp/i18n/de/lectureUnit.json
src/test/java/**/*.java
⚙️ CodeRabbit configuration file
test_naming: descriptive; test_size: small_specific; fixed_data: true; junit5_features: true; assert_use: assertThat; assert_specificity: true; archunit_use: enforce_package_rules; db_query_count_tests: track_performance; util_service_factory_pattern: true; avoid_db_access: true; mock_strategy: static_mocks; context_restart_minimize: true
Files:
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.javasrc/test/java/de/tum/cit/aet/artemis/lecture/LectureTranscriptionServiceIntegrationTest.java
🧠 Learnings (17)
📚 Learning: 2024-11-02T22:57:57.717Z
Learnt from: florian-glombik
Repo: ls1intum/Artemis PR: 9656
File: src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/attachment-unit-form/attachment-unit-form.component.ts:69-71
Timestamp: 2024-11-02T22:57:57.717Z
Learning: In the `src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/attachment-unit-form/attachment-unit-form.component.ts`, the `isFormValid` computed property intentionally uses a logical OR between `this.statusChanges() === 'VALID'` and `this.fileName()` to mirror the original `isSubmitPossible` getter, ensuring consistent form validation behavior.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/lecture-units.component.htmlsrc/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.htmlsrc/main/webapp/app/lecture/manage/lecture-units/edit-attachment-video-unit/edit-attachment-video-unit.component.htmlsrc/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.tssrc/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.htmlsrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts
📚 Learning: 2025-10-10T17:12:35.471Z
Learnt from: marlonnienaber
Repo: ls1intum/Artemis PR: 11436
File: src/main/webapp/app/lecture/manage/lecture-series-create/lecture-series-create.component.ts:356-361
Timestamp: 2025-10-10T17:12:35.471Z
Learning: In the LectureSeriesCreateComponent (src/main/webapp/app/lecture/manage/lecture-series-create/lecture-series-create.component.ts), the rawExistingLectures input contains only persisted Lecture entities from the database, so their id field is guaranteed to be non-null despite the Lecture type having id?: number. The cast to ExistingLecture at line 359 is therefore safe.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/lecture-units.component.htmlsrc/main/webapp/app/lecture/manage/lecture-units/edit-attachment-video-unit/edit-attachment-video-unit.component.htmlsrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts
📚 Learning: 2025-04-01T17:19:55.677Z
Learnt from: tobias-lippert
Repo: ls1intum/Artemis PR: 10610
File: src/test/javascript/spec/service/guided-tour.service.spec.ts:193-193
Timestamp: 2025-04-01T17:19:55.677Z
Learning: In the guide tour service tests, the `router.navigateByUrl` mock should remain synchronous (returning boolean) rather than returning a Promise to maintain compatibility with existing test logic that depends on synchronous behavior.
Applied to files:
src/main/webapp/app/lecture/manage/services/lecture-transcription.service.spec.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts
📚 Learning: 2024-10-10T11:42:23.069Z
Learnt from: pzdr7
Repo: ls1intum/Artemis PR: 9443
File: src/test/javascript/spec/component/hestia/git-diff-report/git-diff-modal.component.spec.ts:55-60
Timestamp: 2024-10-10T11:42:23.069Z
Learning: In `git-diff-report-modal.component.spec.ts`, using `fakeAsync` and `tick` does not work for handling asynchronous operations in the tests; alternative methods are needed.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts
📚 Learning: 2025-09-01T10:20:40.706Z
Learnt from: Michael-Breu-UIbk
Repo: ls1intum/Artemis PR: 10989
File: src/main/webapp/app/programming/manage/detail/programming-exercise-detail.component.with-sharing.spec.ts:132-149
Timestamp: 2025-09-01T10:20:40.706Z
Learning: In the Artemis codebase, Angular component test files for ProgrammingExerciseDetailComponent follow a pattern where the component is imported but not explicitly declared in TestBed.configureTestingModule(), yet TestBed.createComponent() still works successfully. This pattern is consistently used across test files like programming-exercise-detail.component.spec.ts and programming-exercise-detail.component.with-sharing.spec.ts.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts
📚 Learning: 2025-08-21T17:30:20.530Z
Learnt from: MoritzSpengler
Repo: ls1intum/Artemis PR: 11297
File: src/main/webapp/app/quiz/shared/questions/drag-and-drop-question/drag-and-drop-question.component.spec.ts:34-34
Timestamp: 2025-08-21T17:30:20.530Z
Learning: FitTextDirective in src/main/webapp/app/quiz/shared/fit-text/fit-text.directive.ts is a standalone directive marked with standalone: true, so it should be imported in TestBed imports array, not declarations array.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts
📚 Learning: 2024-11-07T00:36:51.500Z
Learnt from: florian-glombik
Repo: ls1intum/Artemis PR: 9694
File: src/main/webapp/app/shared/date-time-picker/date-time-picker.component.ts:29-29
Timestamp: 2024-11-07T00:36:51.500Z
Learning: In the Angular `FormDateTimePickerComponent` in `src/main/webapp/app/shared/date-time-picker/date-time-picker.component.ts`, the `value` model property may sometimes be a `string` because the component is used in multiple places where a `string` is passed. Therefore, changing its type from `any` to a more specific type could cause issues.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.tssrc/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.ts
📚 Learning: 2024-10-20T22:00:52.335Z
Learnt from: pzdr7
Repo: ls1intum/Artemis PR: 9505
File: src/test/javascript/spec/integration/code-editor/code-editor-container.integration.spec.ts:179-181
Timestamp: 2024-10-20T22:00:52.335Z
Learning: In `src/test/javascript/spec/integration/code-editor/code-editor-container.integration.spec.ts`, `ResizeObserver` is mocked within the `beforeEach` block.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts
📚 Learning: 2025-09-03T11:25:50.530Z
Learnt from: marlonnienaber
Repo: ls1intum/Artemis PR: 11308
File: src/main/webapp/app/core/calendar/shared/util/calendar-util.ts:4-4
Timestamp: 2025-09-03T11:25:50.530Z
Learning: The Artemis project uses a centralized dayjs configuration approach. All dayjs plugins, including isoWeek, are configured globally in `src/main/webapp/app/core/config/dayjs.ts`, so local plugin imports and dayjs.extend() calls in individual files are redundant and should be removed.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.ts
📚 Learning: 2024-10-08T15:35:48.767Z
Learnt from: pzdr7
Repo: ls1intum/Artemis PR: 9407
File: src/test/javascript/spec/component/shared/monaco-editor/monaco-editor-communication-action.integration.spec.ts:46-46
Timestamp: 2024-10-08T15:35:48.767Z
Learning: In integration tests, it's acceptable to import the actual `MonacoEditorComponent` instead of mocking it.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.ts
📚 Learning: 2024-10-08T15:35:52.595Z
Learnt from: florian-glombik
Repo: ls1intum/Artemis PR: 8597
File: src/main/webapp/app/exercises/programming/shared/build-details/programming-exercise-repository-and-build-plan-details.component.ts:52-59
Timestamp: 2024-10-08T15:35:52.595Z
Learning: When handling errors in Angular components, ensure to integrate with the alert service for consistent error display across the application.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.tssrc/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts
📚 Learning: 2024-10-13T12:03:02.430Z
Learnt from: pzdr7
Repo: ls1intum/Artemis PR: 9463
File: src/test/javascript/spec/component/shared/monaco-editor/monaco-editor.service.spec.ts:50-55
Timestamp: 2024-10-13T12:03:02.430Z
Learning: In `src/test/javascript/spec/component/shared/monaco-editor/monaco-editor.service.spec.ts`, when a function is called multiple times in a test, use `toHaveBeenCalledTimes` and `toHaveBeenNthCalledWith` assertions instead of `toHaveBeenCalledExactlyOnceWith`.
Applied to files:
src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts
📚 Learning: 2025-08-15T02:30:19.063Z
Learnt from: SamuelRoettgermann
Repo: ls1intum/Artemis PR: 11111
File: src/main/webapp/app/core/admin/exam-rooms/exam-rooms.component.ts:148-152
Timestamp: 2025-08-15T02:30:19.063Z
Learning: In Artemis Angular components, the DeleteDialogService uses an EventEmitter-based pattern rather than direct Observable subscription. The correct usage is: 1) Create an EventEmitter<{ [key: string]: boolean }>, 2) Subscribe to the emitter to perform the actual delete operation, 3) Call deleteDialogService.openDeleteDialog() with a configuration object containing the emitter, deleteQuestion translation key, buttonType, actionType, dialogError observable, and other options. The service handles the dialog lifecycle and emits through the provided emitter when the user confirms the deletion.
Applied to files:
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.ts
📚 Learning: 2025-08-11T13:22:05.140Z
Learnt from: Wallenstein61
Repo: ls1intum/Artemis PR: 10989
File: src/test/java/de/tum/cit/aet/artemis/programming/service/sharing/ExerciseSharingResourceImportTest.java:128-131
Timestamp: 2025-08-11T13:22:05.140Z
Learning: In the ExerciseSharingResourceImportTest class in Artemis, mockServer.verify() is not needed in the tearDown method as the test design doesn't require strict verification of all mocked HTTP expectations. The mockServer field is managed differently in this test class.
Applied to files:
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
📚 Learning: 2024-10-20T21:59:11.630Z
Learnt from: pzdr7
Repo: ls1intum/Artemis PR: 9505
File: src/main/webapp/app/exercises/programming/shared/code-editor/monaco/code-editor-monaco.component.html:9-9
Timestamp: 2024-10-20T21:59:11.630Z
Learning: In Angular templates within the Artemis project (e.g., `src/main/webapp/app/exercises/programming/shared/code-editor/monaco/code-editor-monaco.component.html`), properties like `selectedFile()`, `readOnlyManualFeedback()`, `highlightDifferences()`, and `course()` are signals. It is appropriate to call these signals directly in the template.
Applied to files:
src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts
📚 Learning: 2025-08-08T22:22:20.043Z
Learnt from: SamuelRoettgermann
Repo: ls1intum/Artemis PR: 11111
File: src/main/webapp/app/core/admin/exam-rooms/exam-rooms.component.ts:70-79
Timestamp: 2025-08-08T22:22:20.043Z
Learning: In the Artemis Angular components (such as `exam-rooms.component.ts`), error handling for data loading failures can be implemented by setting the data signal to `undefined`. The template then automatically displays appropriate error messages through conditional rendering with if/else blocks and translation keys, without requiring explicit error status management in the component logic.
Applied to files:
src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts
📚 Learning: 2024-06-10T19:44:09.116Z
Learnt from: florian-glombik
Repo: ls1intum/Artemis PR: 8451
File: src/main/webapp/app/exercises/programming/shared/lifecycle/programming-exercise-lifecycle.component.html:187-187
Timestamp: 2024-06-10T19:44:09.116Z
Learning: Use `artemisTranslate` for handling translations in Angular templates within the Artemis platform, as per the project-specific requirements.
Applied to files:
src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts
🧬 Code graph analysis (4)
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.ts (1)
src/test/playwright/support/baseFixtures.ts (1)
expect(40-40)
src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts (1)
src/test/javascript/spec/helpers/mocks/service/mock-account.service.ts (1)
MockAccountService(8-46)
src/test/java/de/tum/cit/aet/artemis/lecture/LectureTranscriptionServiceIntegrationTest.java (2)
src/test/playwright/support/pageobjects/course/CourseMessagesPage.ts (1)
setName(85-89)src/main/webapp/app/lecture/manage/services/lecture-transcription.service.ts (1)
createTranscription(27-36)
src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts (4)
src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.ts (1)
Component(114-422)src/main/webapp/app/lecture/shared/transcript-viewer/transcript-viewer.component.ts (1)
Component(11-179)src/main/webapp/app/lecture/manage/lecture-units/lecture-units.component.ts (1)
Component(29-378)src/main/webapp/app/lecture/shared/models/transcript-segment.model.ts (1)
TranscriptSegment(4-9)
🪛 GitHub Check: Junit Results
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
[failure] 213-213: cancelNebulaTranscription_notFound()
Junit test cancelNebulaTranscription_notFound() failed java.lang.AssertionError: Status expected:<404> but was:<403>
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (19)
src/main/webapp/i18n/de/lectureUnit.json (1)
190-193: LGTM! German translations follow informal addressing.The new German translations correctly use informal addressing ("du") as required by the coding guidelines, and the phrasing is natural and consistent with existing entries.
src/main/webapp/i18n/en/lectureUnit.json (1)
190-193: LGTM! English translations are clear and consistent.The new English translation keys are grammatically correct and provide clear, user-friendly messages for the cancellation flow.
src/main/webapp/app/lecture/manage/services/lecture-transcription.service.spec.ts (1)
84-102: LGTM! Cancellation tests provide good coverage.The two new test cases properly validate both success and error scenarios for the cancellation flow, checking the HTTP DELETE method, endpoint, and boolean return values.
src/main/webapp/app/lecture/manage/lecture-units/edit-attachment-video-unit/edit-attachment-video-unit.component.html (1)
7-7: LGTM! Lecture unit ID binding is correctly implemented.The new
[lectureUnitId]binding properly passes the attachment video unit's ID to the form component, with appropriate optional chaining to handle undefined values during initialization.src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.html (1)
168-177: LGTM! Cancel button UI is well-implemented.The restructured alert provides a clean two-column layout with the cancel button properly positioned. The disabled state binding prevents race conditions, and the danger button styling appropriately signals a destructive action.
src/main/webapp/app/lecture/manage/lecture-units/lecture-units.component.html (1)
45-45: LGTM! Lecture unit ID binding is correctly propagated.The new binding properly passes the lecture unit ID from the parent component to the form, maintaining consistency with the edit flow and using appropriate optional chaining.
src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.html (1)
45-68: LGTM! Transcription status UI with proper authorization.The new transcription status block is well-structured with:
- Clear visual states for PENDING/PROCESSING/FAILED
- Proper authorization check ensuring only editors can access the cancel button (line 53)
- Loading state management with
isCancelling()to prevent race conditions- Appropriate icon usage for different states
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java (1)
281-281: The code is correct as written—HTTP POST is required by the Nebula API specification.The integration tests in
NebulaTranscriptionResourceIntegrationTest.java(lines 201, 267) confirm that the Nebula cancellation endpoint at/transcribe/cancel/{jobId}expects POST, not DELETE. The code at line 281 correctly usesHttpMethod.POST. While DELETE is a common RESTful convention for cancellation operations, the Nebula API explicitly requires POST, and the current implementation aligns with that specification.Likely an incorrect or invalid review comment.
src/main/webapp/app/lecture/manage/services/lecture-transcription.service.ts (1)
66-75: cancelTranscription implementation is consistent and clearThe endpoint path, status handling, and error mapping to
falsealign with the existing methods in this service and the new backend DELETE route; no issues from my side here.src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.spec.ts (2)
9-11: Test DI setup for modal/transcription/alert services looks correctMocking
NgbModal,LectureTranscriptionService, andAlertServiceviaMockProviderand injecting them inbeforeEachmatches how the component under test will use these dependencies; no issues here.Also applies to: 22-23, 29-31, 49-51, 58-60
760-838: Cancellation flow tests comprehensively cover modal outcomesThe four new specs exercise confirm, dismiss, boolean-false, and thrown-error branches, correctly asserting modal usage, service invocation (or lack thereof), alert calls, and
transcriptionStatusupdates. This gives good confidence in the cancel flow behavior.src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.spec.ts (2)
2-2: New test wiring for transcription/cancellation dependencies is appropriateThe added mocks (
mockLectureTranscriptionService,MockAccountService,MockProviderfor modal and alert) and providers forAttachmentVideoUnitServiceandLectureTranscriptionServiceare consistent with the component’s dependencies and allow focused testing of the cancel flow.Also applies to: 14-17, 34-37, 61-62, 64-68, 77-83, 90-91
411-493: AttachmentVideoUnit cancel-transcription specs are well‑structuredThe four new tests correctly simulate modal resolve/reject, success/failure/error responses from
cancelTranscription, and assert alerts andtranscriptionStatusupdates accordingly. Behavior mirrors the form component tests and gives solid coverage of the UI cancel flow.src/main/java/de/tum/cit/aet/artemis/nebula/web/NebulaTranscriptionResource.java (1)
17-24: DELETE endpoint for cancelling transcriptions is aligned with client and serviceThe new
@DeleteMappingpath, security annotation, logging, and delegation tolectureTranscriptionService.cancelNebulaTranscriptionare consistent with the existing start endpoint and the Angular client URL; no issues here.Also applies to: 72-85
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java (1)
8-8: Cancel integration tests exercise the main happy/error paths wellThe new tests for successful cancel, completed/failed-status bad requests, student forbidden, and Nebula error cover the important behaviors of the DELETE endpoint and validate repository state where relevant; overall structure and mocking strategy look good.
Also applies to: 35-35, 190-209, 217-272
src/test/java/de/tum/cit/aet/artemis/lecture/LectureTranscriptionServiceIntegrationTest.java (2)
219-246: Success-path integration test looks solidCreating a persisted lecture/unit, mocking the Nebula cancel call with the concrete URL, and asserting the transcription is removed gives good end‑to‑end coverage of the happy path. No issues spotted.
324-349: Nebula error handling test is preciseMocking
nebulaRestTemplate.exchange(..)to throw and asserting aResponseStatusExceptionwith the “Failed to cancel transcription” message validates the wrapping/error translation nicely. This gives good confidence that upstream Nebula failures surface correctly.src/main/webapp/app/lecture/manage/lecture-units/attachment-video-unit-form/attachment-video-unit-form.component.ts (1)
13-22: New dependencies and state wiring are consistentInjecting
LectureTranscriptionService,NgbModal, andAlertService, addinglectureUnitIdas an input, and trackingisCancellingvia a signal all fit well with the existing signal‑based design. The earlyif (!unitId) return;check in the cancel flow ensures you won’t accidentally call the backend without a valid unit id, assuming the template only shows the button when a unit id is actually available.Also applies to: 128-139
src/main/webapp/app/lecture/overview/course-lectures/attachment-video-unit/attachment-video-unit.component.ts (1)
4-43: Transcription-related imports, DI, and state exposure look well integratedBringing in
TranscriptionStatus,faTimes,FaIconComponent, and injectingAccountService,AlertService, andNgbModal, plus exposingtranscriptionStatus/isCancellingsignals and theTranscriptionStatusenum for the template, all line up with the new UI requirements and existing patterns in this module.Also applies to: 55-57, 63-66, 70-72
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
Show resolved
Hide resolved
github-project-automation
bot
moved this from Work In Progress
to Ready For Review
in Artemis Development
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java (3)
192-209: Add test coverage for PROCESSING status.The success test only covers
TranscriptionStatus.PENDING, but according to the PR objectives, cancellation is allowed for both PENDING and PROCESSING statuses. Consider adding a similar test case for PROCESSING to ensure complete coverage of valid cancellation scenarios.Additionally, line 201 hardcodes the Nebula URL
"http://localhost:8080/transcribe/cancel/job-123". If this URL is configurable or might change, consider usinganyString()or extracting the base URL from configuration for more maintainable tests.
201-201: Use consistent mock matching patterns.Line 201 uses
eq("http://localhost:8080/transcribe/cancel/job-123")to match the URL, while line 268 usesanyString()for the same parameter. For consistency and maintainability, consider usinganyString()in both places unless you specifically need to verify the exact URL construction.Also applies to: 268-268
190-271: Consider database query count tracking.As per coding guidelines, integration tests should track database query performance (
db_query_count_tests: track_performance). While these tests primarily verify REST endpoint behavior and authorization, consider adding query count assertions for the success path (lines 192-209) to ensure the cancellation operation doesn't inadvertently trigger N+1 queries or excessive database hits.This is particularly relevant for the
findByLectureUnit_Idcall at line 207 and any queries triggered by the authorization checks.As per coding guidelines, database query performance tracking is recommended for integration tests.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/test/java/**/*.java
⚙️ CodeRabbit configuration file
test_naming: descriptive; test_size: small_specific; fixed_data: true; junit5_features: true; assert_use: assertThat; assert_specificity: true; archunit_use: enforce_package_rules; db_query_count_tests: track_performance; util_service_factory_pattern: true; avoid_db_access: true; mock_strategy: static_mocks; context_restart_minimize: true
Files:
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
🧠 Learnings (1)
📚 Learning: 2025-08-11T13:22:05.140Z
Learnt from: Wallenstein61
Repo: ls1intum/Artemis PR: 10989
File: src/test/java/de/tum/cit/aet/artemis/programming/service/sharing/ExerciseSharingResourceImportTest.java:128-131
Timestamp: 2025-08-11T13:22:05.140Z
Learning: In the ExerciseSharingResourceImportTest class in Artemis, mockServer.verify() is not needed in the tearDown method as the test design doesn't require strict verification of all mocked HTTP expectations. The mockServer field is managed differently in this test class.
Applied to files:
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Build and Push Docker Image / Build linux/arm64 Docker Image for ls1intum/artemis
- GitHub Check: Build and Push Docker Image / Build linux/amd64 Docker Image for ls1intum/artemis
- GitHub Check: Build .war artifact
- GitHub Check: client-tests
- GitHub Check: client-style
- GitHub Check: client-tests-selected
- GitHub Check: server-style
- GitHub Check: server-tests
- GitHub Check: bean-instantiation-check
- GitHub Check: Analyse
🔇 Additional comments (1)
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java (1)
8-8: LGTM!The new imports are necessary for the cancellation test methods.
Also applies to: 34-34
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
Show resolved
Hide resolved
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
|||||||||||||||||||||||||||
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java (4)
34-34: Use importedLectureTranscriptionconsistentlyNow that
LectureTranscriptionis imported, you can simplify the earlier declaration at line 119 from
var existingTranscription = new de.tum.cit.aet.artemis.lecture.domain.LectureTranscription();to
var existingTranscription = new LectureTranscription();for consistency and to avoid mixing FQNs with imports.
190-209: Successful cancel path is well covered; URL matcher could be less brittleThe test correctly seeds a PENDING transcription, stubs Nebula to return 200, and asserts the record is removed from the repository — this validates the happy path nicely.
Minor optional improvement: hard‑coding the full cancel URL (
http://localhost:8080/...) in the stub couples the test to the exact base URL configuration. Matching only on the job id (e.g. viaanyString()or a custom matcher that checksendsWith("/transcribe/cancel/job-123")) would make the test more resilient to configuration changes while still asserting the correct job id is used.
225-249: Terminal states (COMPLETED/FAILED) correctly rejectedThe two tests for COMPLETED and FAILED transcriptions ensure that cancellation attempts return
400 BAD_REQUEST, which captures the intended “do not cancel finished jobs” behavior.If you want slightly stronger regression protection, you could additionally assert that the transcription is still present after the DELETE, e.g.:
assertThat(lectureTranscriptionRepository.findByLectureUnit_Id(lectureUnit.getId())).hasSize(1);to guard against accidental deletion in these error cases.
264-277: Nebula error mapped to 500; consider asserting transcription is retainedThe test correctly simulates a
RestClientExceptionfrom Nebula and asserts500 INTERNAL_SERVER_ERROR, which matches the intended error propagation.For extra safety, you might also assert that the transcription still exists after the failed cancel attempt to ensure the service never deletes the record when Nebula fails:
assertThat(lectureTranscriptionRepository.findByLectureUnit_Id(lectureUnit.getId())).hasSize(1);This would firmly pin the “no side effects on upstream failure” contract.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/test/java/**/*.java
⚙️ CodeRabbit configuration file
test_naming: descriptive; test_size: small_specific; fixed_data: true; junit5_features: true; assert_use: assertThat; assert_specificity: true; archunit_use: enforce_package_rules; db_query_count_tests: track_performance; util_service_factory_pattern: true; avoid_db_access: true; mock_strategy: static_mocks; context_restart_minimize: true
Files:
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
🧠 Learnings (3)
📚 Learning: 2025-08-11T13:22:05.140Z
Learnt from: Wallenstein61
Repo: ls1intum/Artemis PR: 10989
File: src/test/java/de/tum/cit/aet/artemis/programming/service/sharing/ExerciseSharingResourceImportTest.java:128-131
Timestamp: 2025-08-11T13:22:05.140Z
Learning: In the ExerciseSharingResourceImportTest class in Artemis, mockServer.verify() is not needed in the tearDown method as the test design doesn't require strict verification of all mocked HTTP expectations. The mockServer field is managed differently in this test class.
Applied to files:
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
📚 Learning: 2024-06-10T19:44:09.116Z
Learnt from: valentin-boehm
Repo: ls1intum/Artemis PR: 7384
File: src/test/java/de/tum/in/www1/artemis/exam/StudentExamIntegrationTest.java:2836-2846
Timestamp: 2024-06-10T19:44:09.116Z
Learning: The `testAbandonStudentExamNotInTime` method does not require additional checks to verify the state of `studentExam1` after receiving a `HttpStatus.FORBIDDEN` because the control flow in the `StudentExamResource` is straightforward and ensures no state change occurs.
Applied to files:
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
📚 Learning: 2024-06-10T19:44:09.116Z
Learnt from: valentin-boehm
Repo: ls1intum/Artemis PR: 7384
File: src/test/java/de/tum/in/www1/artemis/exam/StudentExamIntegrationTest.java:988-993
Timestamp: 2024-06-10T19:44:09.116Z
Learning: The `testSubmitStudentExam_differentUser` method does not require additional checks to verify the state of `studentExam1` after receiving a `HttpStatus.FORBIDDEN` because the control flow in the `StudentExamResource` is straightforward and ensures no state change occurs.
Applied to files:
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Build and Push Docker Image / Build linux/amd64 Docker Image for ls1intum/artemis
- GitHub Check: Build .war artifact
- GitHub Check: bean-instantiation-check
- GitHub Check: client-style
- GitHub Check: client-tests
- GitHub Check: server-tests
- GitHub Check: server-style
- GitHub Check: client-tests-selected
- GitHub Check: Analyse
🔇 Additional comments (4)
src/test/java/de/tum/cit/aet/artemis/lecture/NebulaTranscriptionResourceIntegrationTest.java (4)
8-8: Static import fordelete()is appropriateImporting
deletefromMockMvcRequestBuildersfor the new DELETE tests is correct and keeps the test code readable.
211-216: 403 expectation for non‑existent lecture unit matches security semanticsThis test now correctly expects
403 FORBIDDENwhen the lecture unit id is unknown, which aligns with@EnforceAtLeastEditorInLectureUnitdenying access before the controller can check for a transcription.
218-223: Good edge‑case test for valid unit without transcription (404)This test nicely covers the “lecture unit exists but no transcription record” case and asserts
404 NOT_FOUND, matching the documented service behavior.
251-262: Authorization test for student role is clear and focusedThis test cleanly verifies that a USER cannot cancel transcriptions and that the endpoint responds with
403 FORBIDDEN, which is sufficient without extra state assertions.
End-to-End (E2E) Test Results Summary
|
|||||||||||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java
Outdated
Show resolved
Hide resolved
Capture the ResponseEntity from the Nebula cancellation REST call
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java (1)
273-296: Align error handling consistency and clean up stale failure tracking on successful cancellationTwo optional improvements:
The explicit
elsebranch checkingresponse.getStatusCode().is2xxSuccessful()is inconsistent withstartNebulaTranscription, which relies on exceptions. SincenebulaRestTemplateis a custom-qualified bean, verify its error handler configuration; if it uses the defaultResponseErrorHandler, non-2xx responses will already throw before reaching theelsebranch. Consider either removing the explicit status check and relying solely on exception handling (likestartNebulaTranscription), or document the custom error handling behavior.On successful cancellation, add
failureCountMap.remove(jobId);after deleting the transcription record to prevent stale entries. This keeps in-memory state aligned with the deleted DB record and avoids accumulating entries during polling.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java(1 hunks)src/test/java/de/tum/cit/aet/artemis/lecture/LectureTranscriptionServiceIntegrationTest.java(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/test/java/de/tum/cit/aet/artemis/lecture/LectureTranscriptionServiceIntegrationTest.java
🧰 Additional context used
📓 Path-based instructions (1)
src/main/java/**/*.java
⚙️ CodeRabbit configuration file
naming:CamelCase; principles:{single_responsibility,small_methods,no_duplication}; db:{perf_queries,datetime_not_timestamp}; rest:{stateless,singleton,delegate_logic,http_only,minimal_dtos}; dtos:{java_records,no_entities,min_data,single_resp}; di:constructor_injection; kiss:simple_code; file_handling:os_indep_paths; practices:{least_access,avoid_transactions,code_reuse,static_member_ref,prefer_primitives}; sql:{param_annotation,uppercase,avoid_subqueries};java:avoid_star_imports
Files:
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Build and Push Docker Image / Build linux/amd64 Docker Image for ls1intum/artemis
- GitHub Check: Build and Push Docker Image / Build linux/arm64 Docker Image for ls1intum/artemis
- GitHub Check: Build .war artifact
- GitHub Check: Analyse
- GitHub Check: client-style
- GitHub Check: client-tests-selected
- GitHub Check: server-tests
- GitHub Check: bean-instantiation-check
- GitHub Check: server-style
- GitHub Check: client-tests
🔇 Additional comments (1)
src/main/java/de/tum/cit/aet/artemis/nebula/service/LectureTranscriptionService.java (1)
249-297: Cancellation flow and state validation look correctThe lookup, status checks (blocking COMPLETED/FAILED), Nebula cancel call, and conditional deletion on successful 2xx response all align well with the intended semantics and fix the earlier “delete-before-verifying” issue from the previous review. Logging and error mapping to
ResponseStatusExceptionare consistent withstartNebulaTranscription.
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||
Checklist
General
Server
Client
Motivation and Context
Instructors and editors sometimes need to cancel ongoing transcription jobs for lecture videos, for example when:
-A transcription was started by mistake
-The wrong video was uploaded and needs to be replaced
-The transcription is taking too long or appears to be stuck
-The video content needs to be updated before transcription
Description
1.
LectureTranscriptionService.javacancelNebulaTranscription(Long lectureUnitId)method2.
NebulaTranscriptionResource.javaDELETE /api/nebula/lecture-unit/{lectureUnitId}/transcriber/cancelendpoint@EnforceAtLeastEditorInLectureUnitauthorization3. Integration Tests
LectureTranscriptionServiceIntegrationTest.javaNebulaTranscriptionResourceIntegrationTest.javaClient side Changes
1.
LectureTranscriptionServicecancelTranscription(lectureUnitId: number): Observable<boolean>method2.
AttachmentVideoUnitComponent(student/instructor view)ConfirmAutofocusModalComponentfor user confirmation3.
AttachmentVideoUnitFormComponent(edit mode)Steps for Testing
Prerequisites
Warning
This PR can only be tested together with the corresponding PR on edutelligence.
Test case 1
Test case 2
Test case 3
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
Summary by CodeRabbit
New Features
Localization
Tests
✏️ Tip: You can customize this high-level summary in your review settings.