Skip to content

Conversation

@LangArthur
Copy link
Contributor

@LangArthur LangArthur commented Oct 28, 2025

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.7.10
Command Line Tools 2.11.5

Verification

Have you

@macportsbot
Copy link

Notifying maintainers:
@barracuda156 for port wangle.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Oct 28, 2025
@LangArthur
Copy link
Contributor Author

Hi!

I am new to MacPorts, so the patch might not be the optimal one.

I am afraid that in some case, you want to install wangle without any other clang version than the one installed by Xcode. Is there a way to handle that ?
Otherwise, should I use the variant to have a variant "no_xcode_clang" or something similar ?

ps : I'm doing the test for the linter and some of the missing verification. This pr with be ready for review as soon as done.

Copy link
Contributor

@barracuda156 barracuda156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it build on Catalina with Apple clang? Big Sur has 1300, and < 1200 are already blacklisted. I would just change the threshold to < 1400.

@LangArthur
Copy link
Contributor Author

It does build on catalina with Apple clang (cf. https://ports.macports.org/port/wangle/details/).

And also it works with < 1400 so definitely a better fix 👍

@LangArthur LangArthur force-pushed the wangle/fix-compilation-big-sur branch from 059a7b9 to 740cba4 Compare October 28, 2025 15:06
@LangArthur LangArthur force-pushed the wangle/fix-compilation-big-sur branch from 740cba4 to a7d59d0 Compare October 28, 2025 15:23
@LangArthur
Copy link
Contributor Author

seems ready now :)

@LangArthur LangArthur marked this pull request as ready for review October 28, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer: open Affects an openmaintainer port type: bugfix

Development

Successfully merging this pull request may close these issues.

3 participants