Skip to content

translate-toolkit: update to 3.16.3 #29928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

translate-toolkit: update to 3.16.3 #29928

wants to merge 1 commit into from

Conversation

@trustbyte
Copy link
Contributor

@trustbyte trustbyte commented Nov 3, 2025

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 26.0.1 25A362 arm64
Command Line Tools 26.0.0.0.1.1757719676

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

macportsbot commented Nov 3, 2025

Notifying maintainers:
@l2dy for port translate-toolkit.

@trustbyte
Copy link
Contributor Author

trustbyte commented Nov 3, 2025

blocked by #29927

@trustbyte
Copy link
Contributor Author

trustbyte commented Nov 3, 2025

And it needs more than the blocker but checking tomorrow:
"setuptools>=61.2",
"types-lxml==2025.3.30",
"wcwidth-stubs==0.2.14.0"

@trustbyte trustbyte force-pushed the translate-toolkit_3163 branch from ea893a3 to 442c0b8 Compare November 4, 2025 20:51
@trustbyte trustbyte force-pushed the translate-toolkit_3163 branch from 61a3073 to 9d25f3f Compare November 4, 2025 20:55
@trustbyte trustbyte marked this pull request as ready for review November 4, 2025 21:03
l2dy
l2dy reviewed Nov 5, 2025
View reviewed changes
textproc/translate-toolkit/Portfile
size 1466431
checksums rmd160 d86252dce77fead122e0da8ebddc2147d2aec9d5 \
sha256 d9656526a8bb0f0a88a16a08ed463036589cd34af059daf80aaaa90b9246586c \
size 536719
Copy link
Member

@l2dy l2dy Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new distfile is almost a third of the original in size, have you checked the difference?

Copy link
Contributor Author

@trustbyte trustbyte Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you mean I took a wrong file?
What should I look for in the archive?

Copy link
Member

@l2dy l2dy Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use diffoscope or maybe just compare the file list to see what have changed. If the change is reasonable, then we are good to merge this.

Copy link
Contributor Author

@trustbyte trustbyte Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 182 562 byte directly downloaded from the https://github.com/translate/translate/archive/refs/tags/3.16.3.tar.gz

No idea why the checksum -d reports this:

EBUG: fetch phase started at Fri Nov  7 16:42:26 CET 2025
--->  Fetching distfiles for translate-toolkit
DEBUG: Executing org.macports.fetch (translate-toolkit)
DEBUG: Privilege de-escalation not attempted as not running as root.
DEBUG: checksum phase started at Fri Nov  7 16:42:26 CET 2025
--->  Verifying checksums for translate-toolkit
DEBUG: Executing org.macports.checksum (translate-toolkit)
--->  Checksumming translate_toolkit-3.16.3.tar.gz
DEBUG: Calculated (rmd160) is d86252dce77fead122e0da8ebddc2147d2aec9d5
DEBUG: Correct (rmd160) checksum for translate_toolkit-3.16.3.tar.gz
DEBUG: Calculated (sha256) is d9656526a8bb0f0a88a16a08ed463036589cd34af059daf80aaaa90b9246586c
DEBUG: Correct (sha256) checksum for translate_toolkit-3.16.3.tar.gz
DEBUG: Calculated (size) is 536719
DEBUG: Correct (size) checksum for translate_toolkit-3.16.3.tar.gz

Copy link
Contributor Author

@trustbyte trustbyte Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But again we get from the pypi, right?
There is half the size:
https://pypi.org/project/translate-toolkit/#translate_toolkit-3.16.3.tar.gz

Copy link
Contributor Author

@trustbyte trustbyte Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, no tests and no docs in pypi.
Good enough, right?

Copy link
Member

@l2dy l2dy Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, no tests and no docs in pypi. Good enough, right?

Do you mean that compared to 3.12.2, the 3.16.3 source archive removed tests and docs? Were they part of the files installed for translate-toolkit version 3.12.2 by MacPorts?

Copy link
Contributor Author

@trustbyte trustbyte Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the 3.16.3 exposed via Pypi is without tests and docs.

Yes, the 3.12.2 has tests and docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l2dy l2dy l2dy left review comments

Assignees

@l2dy l2dy

Labels

maintainer: open Affects an openmaintainer port type: enhancement type: update

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trustbyte @macportsbot @l2dy