Add hard delete action #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gagaro
requested changes
Mar 2, 2021
Member
Gagaro
left a comment
Gagaro
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Could you review my comments. Also add a line in CHANGES and check the CI to fix the errors you have.
👍
|
|
||
| if changed: | ||
| for obj in queryset: | ||
| obj.delete(force_policy=HARD_DELETE) |
Member
There was a problem hiding this comment.
It would be better to call the base QuerySet delete to delete in bulk, otherwise it could be very long.
| else: | ||
| self.message_user( | ||
| request, | ||
| "No permission for hard delete. Execute soft delete first.", |
Member
There was a problem hiding this comment.
I would change this to something more explicit such as: "You need to soft delete first in order to hard delete an object."
Gagaro
force-pushed
the
master
branch
2 times, most recently
from
7a52a2a to
0a0daba
Compare
|
Would be nice if u could finish this topic after two years^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.