rendfont.cpp,rendlay.cpp: add font support to <text> components
#14533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support to `<text>` components This adds a "font" attribute to the `<text>` layout component, defaulting to `"default"` if nothing is specified. It also changes the `render_font` constructor to accept not just a single "filename" but a comma-separated list of "filenames". These actually don't seem to be file names at all, but font specifications that may be symbolic (like the default `"Liberation Sans|Regular"` in `font_osd.cpp`), which includes a `|` separator between font family and style. This is in turn used in the Ensoniq VFX family of keyboards to use the ccorrect Bold and Italic styles of a suitable Helvetica-compatible sans-serif font, falling back to "default" of nothing is found. This includes a first choice of an explicitly nonexistent font to demonstrate that the list of fonts is in fact traversed.
…le" type font names.
…me. Instead, just like in the other OS versions, separate out the '|'-separated style information, extract bold/italic styling information from that into a CTFontSymbolicTraits, and then use CTFontDescriptorCreateCopyWithSymbolicTraits to apply those, if any are requested.
Contributor
Author
|
I've verified that the current version of this also works under Windows. Here's what I get with the And with the and after: |
cbrunschen
force-pushed
the
layout_text_font
branch
from
30b58ac to
af23e44
Compare
cbrunschen
force-pushed
the
layout_text_font
branch
from
af23e44 to
38ab52e
Compare
Contributor
Author
|
A friend very kindly ran this on a Mac as well: While this is a JPEG it clearly shows botb Regular, Bold and Italic fonts working, as intended. |
cbrunschen
changed the title
<text> components<text> components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion: improves the layout
<text>component to allow specifying the font and style to use, with fairly minimal changes to the layout rendering system.This adds a "font" attribute to the
<text>layout component, defaulting to"default"if nothing is specified.It also changes the
render_fontconstructor to accept not just a single "filename" but a comma-separated list of "filenames". These actually don't seem to be file names at all, but font specifications that may be symbolic (like the default"Liberation Sans|Regular"infont_osd.cpp), which includes a|separator between font family and style; so adding another separator between different font specifications seems a not unreasonable thing, but is of course open to be changed.This is in turn used in the layouts for the Ensoniq VFX family of keyboards, including the
sd132, to use the correct Bold, Italic and Regular styles of a suitable Helvetica-compatible sans-serif font, falling back to "default" of nothing else is found. This includes a first choice of an explicitly nonexistent font to demonstrate that the list of fonts is in fact traversed.The labels along the thick coloured line - including 'Performance', 'Sequencer' and 'Programming' - are all in Bold; the labels above the buttons - 'Volume', 'Pan', 'Timbre', etc - are all Italic; and the extra little labels between white lines, 'Tracks' and 'Edit', are in Regular style (neither Bold nor Italic).