Add `auto_webmercator` to COG #1893

sharkAndshark · 2025-07-01T03:24:45Z

To fix #1820 .

for more information, see https://pre-commit.ci

sharkAndshark · 2025-07-22T02:16:25Z

During a very intensive project deadline these days, would be back ASAP！

sharkAndshark · 2025-08-16T06:31:22Z

Almost there and a quick verification:

This tiff file is from openlayers examples:

curl -o tci_original.tif https://sentinel-cogs.s3.us-west-2.amazonaws.com/sentinel-s2-l2a-cogs/36/Q/WD/2020/7/S2A_36QWD_20200701_0_L2A/TCI.tif
gdalwarp -t_srs EPSG:3857 tci_original.tif tci_3857.tif
gdal_translate -of COG -co TILING_SCHEME=GoogleMapsCompatible tci_3857.tif tci.tif

---
# Connection keep alive timeout [default: 75]
keep_alive: 75

# The socket address to bind [default: 0.0.0.0:3000]
listen_addresses: '0.0.0.0:3000'

# Number of web server workers
worker_processes: 8

# Amount of memory (in MB) to use for caching tiles [default: 512, 0 to disable]
cache_size_mb: 8

cog:
  auto_web: true
  sources:
    tci: /home/shark/repos/martin/.vscode/cog_auto_web/tci.tif

npm create ol-app my-app
cd my-app

Update the main.js in my-app:

import './style.css';
import {Map, View} from 'ol';
import TileLayer from 'ol/layer/Tile';
import OSM from 'ol/source/OSM';
import XYZ from 'ol/source/XYZ';

const map = new Map({
  target: 'map',
  layers: [
    new TileLayer({
      source: new OSM()
    }),
    new TileLayer({
      source: new XYZ({
        url: 'http://localhost:3000/tci/{z}/{x}/{y}',
        tileSize: 512
      })
    })
  ],
  view: new View({
    center: [3732694, 1882165],
    zoom: 14 
  })
});

sharkAndshark · 2025-08-07T06:06:17Z

martin-tile-utils/src/lib.rs


+/// Convert min/max XYZ tile coordinates to a bounding box values in Web Mercator.
+#[must_use]
+pub fn xyz_to_bbox_webmercator(


we have already a xyz_to_bbox actually but its result is not in 3857

Should we add it here?

Yes, comparing in the doc string the two seems sensible.

Moreover, we should likely use xyz_to_bbox_webmercator in xyz_to_bbox (instead of copy and paste) and rename it to xyz_to_bbox_wgs84

sharkAndshark · 2025-08-16T05:30:45Z

docs/src/sources-cog-files.md

-# Configured with a directory containing `*.tif` or `*.tiff` TIFF files.
-martin /with/tiff/dir1 /with/tiff/dir2
-# Configured with dedicated TIFF file
-martin /path/to/target1.tif /path/to/target2.tiff
-# Configured with a combination of directories and dedicated TIFF files.
-martin /with/tiff/files /path/to/target1.tif /path/to/target2.tiff


Enable auto-web in CLI Next PR.

CommanderStorm · 2025-08-24T14:41:06Z

Two comments (I am not sure if you want a review yet, but think getting these out of the way is nice)

I don't think auto_web is quite self-explanatory.
How about convert_to_web_mercator_quad or something like tiling_scheme: web_mercator_quad?
Would be true by default not be a better call? I think this is what users most likely want..

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

CommanderStorm

I am really happy to see progress on this.

I have left a few comments below, but the three where we need to align on are:

I don't think auto_web is not quite self-explanatory.
How about convert_to_web_mercator_quad or something like tiling_scheme: WebMercatorQuad?
Would be true by default not be a better call? I think this is what users most likely want and this would match the default of maplibre…
Do we need this setting to be per-source configurable, or would this being a global setting be sufficient?

docs/src/sources-cog-files.md

CommanderStorm · 2025-08-26T11:51:50Z

docs/src/sources-cog-files.md

-    - /path/to/target1.tif
-    - /path/to/target2.tiff
+  # Default false
+  # If enabled, martin will automatically serve COG as a [WebMercatorQuad](https://docs.ogc.org/is/17-083r2/17-083r2.html#72) service, the tiles will be cliped and merged internally to be aligned with the Web Mercator grid.


Suggested change

# If enabled, martin will automatically serve COG as a [WebMercatorQuad](https://docs.ogc.org/is/17-083r2/17-083r2.html#72) service, the tiles will be cliped and merged internally to be aligned with the Web Mercator grid.

# If enabled, martin will automatically serve COG as a [WebMercatorQuad](https://docs.ogc.org/is/17-083r2/17-083r2.html#72) service.

# The tiles will be cliped/merged internally to be aligned with the Web Mercator grid.

CommanderStorm · 2025-08-26T11:52:14Z

docs/src/sources-cog-files.md

-    - /path/to/target2.tiff
+  # Default false
+  # If enabled, martin will automatically serve COG as a [WebMercatorQuad](https://docs.ogc.org/is/17-083r2/17-083r2.html#72) service, the tiles will be cliped and merged internally to be aligned with the Web Mercator grid.
+  # Note: Just work for COG files with a Web Mercator CRS (EPSG:3857).


could you clarify this comment?

Welcome any better description!
That's said martin would make the output tiles aligned with the WebMercatoQuad so clients no need to set the customized tilegrid. I would try to make it better again, and any suggestion? I'm pain in English 😂

CommanderStorm · 2025-08-26T12:23:06Z

martin/src/cog/source.rs

            nodata,
            tilejson,
            tileinfo,
+            web_friendly: auto_web,


lets use the same name across the whole api ^^

I thought I have fix this lolll still left one here..... And let's discuss which is better?

auto_web

web_friendly

convert_to_web_mercator_quad

WebMercatorQuad

Other suggestion? Maybe @nyurik have a better idea?

CommanderStorm · 2025-08-26T12:28:53Z

martin/src/cog/source.rs

+/// find a zoom level of google web mercator that is closest to the given resolution
+fn nearest_web_mercator_zoom(resolution: (f64, f64), tile_size: (u32, u32)) -> u8 {
+    let tile_width_in_model = resolution.0 * f64::from(tile_size.0);
+    let mut nearest_zoom = 0u8;
+    let mut min_diff = f64::INFINITY;
+
+    for google_zoom in 0..30 {
+        let tile_length = EARTH_CIRCUMFERENCE / f64::from(1_u32 << google_zoom);
+        let current_diff = (tile_width_in_model - tile_length).abs();
+
+        if current_diff < min_diff {
+            min_diff = current_diff;
+            nearest_zoom = google_zoom;
+        }
    }


this is the only place where google is mentioned

Suggested change

/// find a zoom level of google web mercator that is closest to the given resolution

fn nearest_web_mercator_zoom(resolution: (f64, f64), tile_size: (u32, u32)) -> u8 {

let tile_width_in_model = resolution.0 * f64::from(tile_size.0);

let mut nearest_zoom = 0u8;

let mut min_diff = f64::INFINITY;

for google_zoom in 0..30 {

let tile_length = EARTH_CIRCUMFERENCE / f64::from(1_u32 << google_zoom);

let current_diff = (tile_width_in_model - tile_length).abs();

if current_diff < min_diff {

min_diff = current_diff;

nearest_zoom = google_zoom;

}

}

/// Find the closest web mercator zoom level for the given resolution

fn nearest_web_mercator_zoom(resolution: (f64, f64), tile_size: (u32, u32)) -> u8 {

let tile_width_in_model = resolution.0 * f64::from(tile_size.0);

let mut nearest_zoom = 0u8;

let mut min_diff = f64::INFINITY;

for zoom in 0..30 {

let tile_length = EARTH_CIRCUMFERENCE / f64::from(1_u32 << zoom);

let current_diff = (tile_width_in_model - tile_length).abs();

if current_diff < min_diff {

min_diff = current_diff;

nearest_zoom = zoom;

}

}

CommanderStorm · 2025-08-26T12:29:22Z

martin/src/cog/source.rs

+    let mut nearest_zoom = 0u8;
+    let mut min_diff = f64::INFINITY;
+
+    for google_zoom in 0..30 {


could we use our MAX_ZOOM-constant instead?

CommanderStorm · 2025-08-26T12:32:04Z

martin/src/file_config.rs

        path: PathBuf,
    ) -> impl Future<Output = MartinResult<TileInfoSource>> + Send;

+    fn new_sources_with_config(


lets add a doc comment what this trait-fn does allow to do (per source configurable sources)

CommanderStorm · 2025-08-26T12:34:18Z

martin/src/cog/config.rs

 use crate::{MartinResult, TileInfoSource};

 #[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
 pub struct CogConfig {


I think we should not serialize auto_web if None => add the serde_with marker

sharkAndshark added 14 commits June 23, 2025 10:09

add resolution to Image

05d8465

add auto_web option

4108e8b

add web zoom if auto_web enabled

55a5ee1

add intersect_tiles() to Image

df8c954

wip

209224f

add origin to image

a212c37

add doc

17d0528

reanme func

aaed0d1

refactor

bfe18cc

wip: finish func clip

3a4a946

add crates

c5e4b9a

finish clip method

7981a38

clip imag when web friendly enabled

40b5ee3

wip

c8010ec

sharkAndshark force-pushed the cog_web_5 branch from 28fca35 to c8010ec Compare July 14, 2025 08:49

sharkAndshark and others added 12 commits July 14, 2025 22:48

add doc

32dab67

update cargo lock

1bab765

clippy

f571457

wip: clippy

dbc603a

clippy

e79b088

clean up

0f2ee38

add test cases

02f425a

Merge remote-tracking branch 'maplibre/main' into cog_web_5

1ecd40a

[pre-commit.ci] auto fixes from pre-commit.com hooks

8a9d551

for more information, see https://pre-commit.ci

add auto_web as a source config

acd389e

Merge remote-tracking branch 'maplibre/main' into cog_web_5

cf6ac10

bless test

843c016

Merge branch 'main' into cog_web_5

8292dde

nyurik mentioned this pull request Jul 23, 2025

chore: add pre-commit CI harfbuzz/harfrust#90

Open

sharkAndshark added 11 commits August 15, 2025 21:22

Merge remote-tracking branch 'maplibre/main' into cog_web_5

a348677

bless tests

0145c8e

bless

04c4eb1

fix bug

7d7ac8a

Merge remote-tracking branch 'maplibre/main' into cog_web_5

326fcd8

naming

17308ab

bless

6aad230

Merge remote-tracking branch 'maplibre/main' into cog_web_5

fa372c6

bless

0b1cb8c

add doc

bf8f726

add tests

b6039a7

sharkAndshark commented Aug 16, 2025

View reviewed changes

sharkAndshark added 4 commits August 16, 2025 14:37

cargo clippy

ada9be0

cargo sort

0833a42

Merge remote-tracking branch 'maplibre/main' into cog_web_5

ccba0ee

sort toml

a348df2

sharkAndshark marked this pull request as ready for review August 26, 2025 05:32

Copilot AI review requested due to automatic review settings August 26, 2025 05:32

Merge branch 'main' into cog_web_5

d4b0f83

Copilot AI reviewed Aug 26, 2025

View reviewed changes

CommanderStorm changed the title ~~Add auto_webmercator to COG~~ Add auto_webmercator to COG Aug 26, 2025

CommanderStorm requested changes Aug 26, 2025

View reviewed changes

sharkAndshark and others added 6 commits August 28, 2025 10:55

refactor xyz_to_bbox function

5f194bb

better doc

51270d4

doc improvement

8e35aa1

Merge branch 'main' into cog_web_5

1f04451

Merge branch 'main' into cog_web_5

f4ad640

Merge branch 'main' into cog_web_5

a8e716a

	# If enabled, martin will automatically serve COG as a [WebMercatorQuad](https://docs.ogc.org/is/17-083r2/17-083r2.html#72) service, the tiles will be cliped and merged internally to be aligned with the Web Mercator grid.
	# If enabled, martin will automatically serve COG as a [WebMercatorQuad](https://docs.ogc.org/is/17-083r2/17-083r2.html#72) service.
	# The tiles will be cliped/merged internally to be aligned with the Web Mercator grid.

Uh oh!

Add auto_webmercator to COG #1893

Are you sure you want to change the base?

Add auto_webmercator to COG #1893

Uh oh!

Conversation

sharkAndshark commented Jul 1, 2025

Uh oh!

sharkAndshark commented Jul 22, 2025

Uh oh!

sharkAndshark commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CommanderStorm Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sharkAndshark Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CommanderStorm commented Aug 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

CommanderStorm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sharkAndshark Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add `auto_webmercator` to COG #1893

Add `auto_webmercator` to COG #1893

sharkAndshark commented Aug 16, 2025 •

edited

Loading

CommanderStorm Aug 16, 2025 •

edited

Loading

sharkAndshark Aug 16, 2025 •

edited

Loading

sharkAndshark Aug 28, 2025 •

edited

Loading