core: speed up deserialization using std::to_chars #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-speedup-libmav-conversion
branch
from
093c909 to
f2c62a9
Compare
Collaborator
Author
|
Alternative would be to pull in https://github.com/fmtlib/fmt. |
julianoes
force-pushed
the
pr-speedup-libmav-conversion
branch
2 times, most recently
from
2e2043b to
7f1128c
Compare
When parsing messages, profiling shows that most time is spent in ostream to format the values to string. This adds a test and a faster implementation based on std::to_chars.
julianoes
force-pushed
the
pr-speedup-libmav-conversion
branch
from
7f1128c to
69f1a99
Compare
|
Collaborator
Author
|
@JonasVautherin This reduces CPU usage from 8% to 7% in a typical scenario:
The baseline using the C library and MavlinkPassthrough is 6%. I'm not sure it's worth the complexity at this stage. I'd be more tempted to pull the fmt lib and use that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing messages, profiling shows that most time is spent in ostream to format the values to string.
This adds a test and a faster implementation based on std::to_chars.