Fix nodata type checking for can cast with numpy >2 by putting the nodata in the correct type #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdbartos I've been testing this and confirm this is working well. That being said @ashleymedin , shouldn't the setup.py be updated as well to spec the numpy >= 2.0 version? |
Author
|
Yes @tgrandje I should have added that. Fixed now. |
Owner
|
Thanks, I'm going to take a look at the conflict and try to resolve and get the unit tests running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All nodata was put into a numpy type. This builds on the work of @joelrahman.