Feat/6704 neighbor info on demand #8523
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@thebentern Also weigh in on whether you need me to change anything. |
GUVWAF
reviewed
Nov 4, 2025
| // If the hopLimit is the same as hopStart, then it is a neighbor | ||
| getOrCreateNeighbor(mp.from, mp.from, 0, mp.rx_snr); // Set the broadcast interval to 0, as we don't know it | ||
| } | ||
| if (mp.decoded.want_response && np->neighbors_count == 0) { // want response, and is otherwise empty. |
Member
There was a problem hiding this comment.
want_response packets are handled in callModules(). The cleanest way to implement this is by overriding allocReply(). See e.g. the NodeInfoModule for an example. In this way, the correct request_id is also set, which the recipient uses to link to the request.
Member
There was a problem hiding this comment.
I would also not use a 0 neighbor count for this, because it lets this node think the requester has 0 neighbors. For other requests, e.g. position, we send the requester's position with it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6704
Allows you to requestneighbours from a node.
Node needs to have neighbourInfo turned on, but can have the interval set to 0.
Does not need to have sendViaLora == true.
Uses the 'want response' field with neighbor_count == 0 to indicate that it is a request for neighbor info.
This doesn't seem to be being used by anything in neighbor info, but I added the count == 0 to make sure that we don't get into a situation where they just keep responding to each other.
Added an optional 'sendEmpty' param, so that requests are always responded to.
At the moment it's sent to the requesting node, rather than broadcast, but that's open to discussion.