CLIENT_BASE: Act like ROUTER_LATE for fav'd nodes, instead of like ROUTER

[korbinianbauer]

As requested by @NomDeTom on discord in #transport-layer

Hey, could you do a favour here and make the changes to firmware to make client_base act like router_late for favourite nodes, please?
We're discussing it on the ⁠contributor-hangout , and it's agreed that this is the correct thing to do.

🤝 Attestations

• I have tested that my proposed changes behave as described.
• I have tested that my proposed changes do not cause any obvious regressions on the following devices:
  • Heltec (Lora32) V3
  • LilyGo T-Deck
  • LilyGo T-Beam
  • RAK WisBlock 4631
  • Seeed Studio T-1000E tracker card
  • Other (please specify below)

[GUVWAF]

We should also check for isFromOrToFavoritedNode() here then.

[compumike]

I agree that we should also check isFromOrToFavoritedNode() (because otherwise this will unintentionally move ordinary CLIENT-style rebroadcasts to be later)

[GUVWAF]

@compumike Would like to know your thoughts on this also.

[compumike]

@GUVWAF I didn't hear / don't see any record of the #contributor-hangout conversation, so I don't have context of what problem this change is trying to solve.

But in general I'm okay with this change in behavior! 👍

Net effects of moving CLIENT_BASE to act in the ROUTER_LATE window:

• 🔴 higher latency
• 🔴 higher total airtime / channel congestion (because a message may be rebroadcasted first by a CLIENT and then later by the CLIENT_BASE)
• 🟢 slightly higher reliability of message deliverability
• 🟢 better resistance to misconfiguration (unintended favorites)

Which is a real tradeoff, but also is a totally reasonable set of tradeoffs to make!