Skip to content

Conversation

@mikechristiansen
Copy link

@mikechristiansen mikechristiansen commented Nov 9, 2025

This change to serial.cpp and serial.h corrects the cumultivie rain value "rain" reported by the sensor into rain1h useful for reporting precip to windy.com.
This is my first PR with any project, so welcome feedback!

🤝 Attestations

  • [√ ] I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • [√ ] NRF52 Pro Micro DIY with WS85 Serial.

- Implement 24-hour ring buffer for minute-by-minute rainfall tracking
- Calculate accurate 1h and 24h rainfall totals from cumulative data
- Handle counter resets and spike detection
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

…roved Rain1h calculation to correctly match actual rain fall rates
@mikechristiansen mikechristiansen changed the title Add rolling rainfall accumulator to Serial module for WS85 weather station handling rain correctly. Add rolling rainfall accumulator to Serial module for WS85 weather station handling rain1h Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants