Skip to content

Using AutoCloseable doesn't compile and I am stuck: #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dr0i wants to merge 2 commits into from
Closed

Using AutoCloseable doesn't compile and I am stuck: #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04de1f3
Fix memory leak (#666)
dr0i Feb 10, 2025
d7858f6
WIP use Autocloseable in maps
dr0i Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metamorph-api/src/main/java/org/metafacture/metamorph/api/helpers/AbstractReadOnlyMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
* @param <V> type of values
* @author Markus Michael Geipel
*/
public abstract class AbstractReadOnlyMap<K, V> implements Map<K, V> {
public abstract class AbstractReadOnlyMap<K, V> implements Map<K, V>, AutoCloseable {

@Override
public final int size() {
Expand Down
5 changes: 5 additions & 0 deletions metamorph/src/main/java/org/metafacture/metamorph/maps/FileMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,4 +290,9 @@ public Set<String> keySet() {
return Collections.unmodifiableSet(map.keySet());
}

@Override
public void close() throws IOException {
map.clear();
fileOpener.closeStream();
}
}
4 changes: 4 additions & 0 deletions metamorph/src/main/java/org/metafacture/metamorph/maps/RestMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,8 @@ public void setCharsetName(final String name) {
charsetName = name;
}

@Override
public void close() throws IOException {

}
}
Loading