Skip to content

fix: exception when glob pattern contains constructor #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

fix: exception when glob pattern contains constructor #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9e2dd2
fix: exception when glob pattern contains `constructor`
Jason3S Apr 18, 2025
bfc1c22
Update lib/constants.js
Jason3S May 23, 2025
94e3438
Update constants.js
Jason3S May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ module.exports = {

// Replace globs with equivalent patterns to reduce parsing time.
REPLACEMENTS: {
__proto__: null,
'***': '*',
'**/**': '**',
'**/**/**': '**'
Expand Down
5 changes: 5 additions & 0 deletions test/malicious.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,9 @@ describe('handling of potential regex exploits', () => {
assert(!isMatch('A', `!(${repeat(500)}A)`, { maxLength: 499 }));
}, /Input length: 504, exceeds maximum allowed length: 499/);
});
it('should be able to accept Object instance properties', () => {
assert(isMatch('constructor', 'constructor'), 'valid match');
assert(isMatch('__proto__', '__proto__'), 'valid match');
assert(isMatch('toString', 'toString'), 'valid match');
});
});