Skip to content

Unhide showPopover/togglePopover options #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Dec 4, 2025
Merged

Unhide showPopover/togglePopover options #2266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2201,6 +2201,10 @@ interface ShareData {
url?: string;
}

interface ShowPopoverOptions {
source?: HTMLElement;
}

interface SpeechRecognitionErrorEventInit extends EventInit {
error: SpeechRecognitionErrorCode;
message?: string;
Expand Down Expand Up @@ -2316,6 +2320,10 @@ interface ToggleEventInit extends EventInit {
source?: Element | null;
}

interface TogglePopoverOptions extends ShowPopoverOptions {
force?: boolean;
}

interface TouchEventInit extends EventModifierInit {
changedTouches?: Touch[];
targetTouches?: Touch[];
Expand Down Expand Up @@ -16104,13 +16112,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/showPopover)
*/
showPopover(): void;
showPopover(options?: ShowPopoverOptions): void;
/**
* The **`togglePopover()`** method of the HTMLElement interface toggles a popover element (i.e., one that has a valid popover attribute) between the hidden and showing states.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
*/
togglePopover(options?: boolean): boolean;
togglePopover(options?: TogglePopoverOptions | boolean): boolean;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down
12 changes: 10 additions & 2 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2198,6 +2198,10 @@ interface ShareData {
url?: string;
}

interface ShowPopoverOptions {
source?: HTMLElement;
}

interface SpeechRecognitionErrorEventInit extends EventInit {
error: SpeechRecognitionErrorCode;
message?: string;
Expand Down Expand Up @@ -2313,6 +2317,10 @@ interface ToggleEventInit extends EventInit {
source?: Element | null;
}

interface TogglePopoverOptions extends ShowPopoverOptions {
force?: boolean;
}

interface TouchEventInit extends EventModifierInit {
changedTouches?: Touch[];
targetTouches?: Touch[];
Expand Down Expand Up @@ -16088,13 +16096,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/showPopover)
*/
showPopover(): void;
showPopover(options?: ShowPopoverOptions): void;
/**
* The **`togglePopover()`** method of the HTMLElement interface toggles a popover element (i.e., one that has a valid popover attribute) between the hidden and showing states.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
*/
togglePopover(options?: boolean): boolean;
togglePopover(options?: TogglePopoverOptions | boolean): boolean;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down
12 changes: 10 additions & 2 deletions baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2198,6 +2198,10 @@ interface ShareData {
url?: string;
}

interface ShowPopoverOptions {
source?: HTMLElement;
}

interface SpeechRecognitionErrorEventInit extends EventInit {
error: SpeechRecognitionErrorCode;
message?: string;
Expand Down Expand Up @@ -2313,6 +2317,10 @@ interface ToggleEventInit extends EventInit {
source?: Element | null;
}

interface TogglePopoverOptions extends ShowPopoverOptions {
force?: boolean;
}

interface TouchEventInit extends EventModifierInit {
changedTouches?: Touch[];
targetTouches?: Touch[];
Expand Down Expand Up @@ -16101,13 +16109,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/showPopover)
*/
showPopover(): void;
showPopover(options?: ShowPopoverOptions): void;
/**
* The **`togglePopover()`** method of the HTMLElement interface toggles a popover element (i.e., one that has a valid popover attribute) between the hidden and showing states.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
*/
togglePopover(options?: boolean): boolean;
togglePopover(options?: TogglePopoverOptions | boolean): boolean;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down
12 changes: 10 additions & 2 deletions baselines/ts5.9/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2198,6 +2198,10 @@ interface ShareData {
url?: string;
}

interface ShowPopoverOptions {
source?: HTMLElement;
}

interface SpeechRecognitionErrorEventInit extends EventInit {
error: SpeechRecognitionErrorCode;
message?: string;
Expand Down Expand Up @@ -2313,6 +2317,10 @@ interface ToggleEventInit extends EventInit {
source?: Element | null;
}

interface TogglePopoverOptions extends ShowPopoverOptions {
force?: boolean;
}

interface TouchEventInit extends EventModifierInit {
changedTouches?: Touch[];
targetTouches?: Touch[];
Expand Down Expand Up @@ -16101,13 +16109,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/showPopover)
*/
showPopover(): void;
showPopover(options?: ShowPopoverOptions): void;
/**
* The **`togglePopover()`** method of the HTMLElement interface toggles a popover element (i.e., one that has a valid popover attribute) between the hidden and showing states.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
*/
togglePopover(options?: boolean): boolean;
togglePopover(options?: TogglePopoverOptions | boolean): boolean;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down
17 changes: 0 additions & 17 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,23 +312,6 @@
"nullable": false
}
}
},
"methods": {
"method": {
"togglePopover": {
"signature": {
"0": {
"param": [
{
// dictionary support is Blink only as of 2024-11
"name": "options",
"type": "boolean"
}
]
}
}
}
}
}
},
"MediaMetadata": {
Expand Down
13 changes: 0 additions & 13 deletions inputfiles/removedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,19 +157,6 @@
}
}
},
"HTMLElement": {
"methods": {
"method": {
"showPopover": {
"signature": {
"0": {
"param": ["options"] // Blink only as of 2024-11
}
}
}
}
}
},
"IntersectionObserverEntry": {
"constructor": null // WebKit-only as of 2024-07
},
Expand Down