.Net: Switch MEVD MongoDB Driver to v3.51 #13370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means targetting .NET 4.7.2 for vector data implementations that depend on it. Supressed warnings about disposal since it doesn't do anything yet. # Conflicts: # dotnet/Directory.Packages.props
damieng
changed the title
damieng
changed the title
damieng
changed the title
roji
approved these changes
Nov 24, 2025
| return handler; | ||
| } | ||
| #elif NET462 | ||
| #elif NET462 || NET472 |
Comment on lines
+19
to
+41
| { | ||
| if (value is null) | ||
| { | ||
| return BsonNull.Value; | ||
| } | ||
|
|
||
| if (value.GetType().IsArray) | ||
| { | ||
| if (value is Guid[] guids) | ||
| { | ||
| return new BsonArray(Array.ConvertAll(guids, x => new BsonBinaryData(x, GuidRepresentation.Standard))); | ||
| } | ||
|
|
||
| return new BsonArray(value as Array); | ||
| } | ||
|
|
||
| if (value is Guid guid) | ||
| { | ||
| return new BsonBinaryData(guid, GuidRepresentation.Standard); | ||
| } | ||
|
|
||
| return BsonValue.Create(value); | ||
| } |
Member
There was a problem hiding this comment.
nit: am addicted to switch expressions:
Suggested change
| { | |
| if (value is null) | |
| { | |
| return BsonNull.Value; | |
| } | |
| if (value.GetType().IsArray) | |
| { | |
| if (value is Guid[] guids) | |
| { | |
| return new BsonArray(Array.ConvertAll(guids, x => new BsonBinaryData(x, GuidRepresentation.Standard))); | |
| } | |
| return new BsonArray(value as Array); | |
| } | |
| if (value is Guid guid) | |
| { | |
| return new BsonBinaryData(guid, GuidRepresentation.Standard); | |
| } | |
| return BsonValue.Create(value); | |
| } | |
| => value switch | |
| { | |
| null => BsonNull.Value, | |
| Guid guid => new BsonBinaryData(guid, GuidRepresentation.Standard), | |
| Guid[] guids => new BsonArray(Array.ConvertAll(guids, x => new BsonBinaryData(x, GuidRepresentation.Standard))), | |
| Array array => new BsonArray(array), | |
| _ => BsonValue.Create(value) | |
| }; |
| <AssemblyName>Microsoft.SemanticKernel.Connectors.MongoDB</AssemblyName> | ||
| <RootNamespace>$(AssemblyName)</RootNamespace> | ||
| <TargetFrameworks>net8.0;netstandard2.0;net462</TargetFrameworks> | ||
| <TargetFrameworks>net8.0;net472</TargetFrameworks> |
Member
There was a problem hiding this comment.
Should this also target netstandard2.1, given that MongoDB.Driver targets that? There probably isn't huge value in doing so, but then the MEVD provider is supposed to be a simple layer on top of the driver, so ideally would support whatever the driver supports... Also it's probably pretty trivial to add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Switches the MongoDB Driver to the latest 3.5 release which had a number of breaking changes.
This affects both the MongoDB vector data project and the CosmosMongoDB project.
This fixes #11652 and likely addresses #12707 and partly #10291.
Description
Switches the MongoDB driver to 3.5. Part of the breaking changes is that GUIDs in BSON no longer have a default storage format specified due to the need to switch from the C#-only format to the cross-MongoDB-driver standard format. Setting this is achieved in this PR by way of both a convention for the registry based mode and an alternative to BsonValue.Create in the scenarios where we don't have access to conventions/serialization such as key creation and using the dynamic mapper.
Contribution Checklist
cc @roji