-
Notifications
You must be signed in to change notification settings - Fork 3.6k
enhance: Extract assign policy from balancer and add StoppingBalancer #45858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
|
@weiliu1031 go-sdk check failed, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45858 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 524 524
Lines 82326 82326
=======================================
Hits 68111 68111
Misses 14215 14215
🚀 New features to boost your workflow:
|
- Create new assign package with unified AssignPolicy interface that abstracts segment and channel assignment logic - Implement three assign policies: RoundRobin (for fast loading), RowCount-based, and Score-based assignment strategies - Add AssignPolicyFactory for creating and caching policy instances - Introduce StoppingBalancer to centralize stopping node balance logic that was previously duplicated across multiple balancers - Add BalancerFactory for dynamic balancer creation and caching based on configuration - Refactor existing balancers (ScoreBased, RowCountBased, ChannelLevel) to use the new assign policy abstraction - Move priority_queue and streaming_query_node_channel_helper to assign package - Add comprehensive unit tests for all new components - Add new config parameter for StoppingBalanceAssignPolicy Signed-off-by: Wei Liu <[email protected]>
8cf553c to
8eb630a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #45857