-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix: remove the streamingnode checking when loading segment #45859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
If we enable checking when loading segments, all segment should always be loaded by streamingnode but not 2.5 querynode, make some search and query failure when upgrading. Otherwise, some search and query result will be wrong when upgrading. We choose to disable this checking for now to promise available search and query when upgrading. Signed-off-by: chyezh <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure: Where Example: Please review and update your PR to comply with these guidelines. |
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45859 +/- ##
===========================================
+ Coverage 41.20% 76.19% +34.99%
===========================================
Files 1225 1881 +656
Lines 194107 294008 +99901
===========================================
+ Hits 79982 224033 +144051
+ Misses 113790 62547 -51243
- Partials 335 7428 +7093
🚀 New features to boost your workflow:
|
|
/ci-rerun-ut-go |
|
/ci-rerun-ut-integration |
3 similar comments
|
/ci-rerun-ut-integration |
|
/ci-rerun-ut-integration |
|
/ci-rerun-ut-integration |
issue: #43117
If we enable checking when loading segments, all segment should always be loaded by streamingnode but not 2.5 querynode, make some search and query failure when upgrading. Otherwise, some search and query result will be wrong when upgrading. We choose to disable this checking for now to promise available search and query when upgrading.
also see pr: #43346