Skip to content

Conversation

@chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 26, 2025

issue: #43117

If we enable checking when loading segments, all segment should always be loaded by streamingnode but not 2.5 querynode, make some search and query failure when upgrading. Otherwise, some search and query result will be wrong when upgrading. We choose to disable this checking for now to promise available search and query when upgrading.

also see pr: #43346

If we enable checking when loading segments, all segment should always be loaded by streamingnode but not 2.5 querynode, make some search and query failure when upgrading.
Otherwise, some search and query result will be wrong when upgrading. We choose to disable this checking for now to promise available search and query when upgrading.

Signed-off-by: chyezh <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2025

@chyezh

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  • build(deps): for dependency updates from Dependabot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@chyezh chyezh changed the title remove the streamingnode checking when loading segment fix: remove the streamingnode checking when loading segment Nov 26, 2025
@chyezh chyezh added this to the 2.6.7 milestone Nov 26, 2025
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.19%. Comparing base (4b14ab1) to head (890f4a9).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45859       +/-   ##
===========================================
+ Coverage   41.20%   76.19%   +34.99%     
===========================================
  Files        1225     1881      +656     
  Lines      194107   294008    +99901     
===========================================
+ Hits        79982   224033   +144051     
+ Misses     113790    62547    -51243     
- Partials      335     7428     +7093     
Components Coverage Δ
Client 78.17% <ø> (∅)
Core 82.85% <ø> (ø)
Go 74.29% <100.00%> (+64.83%) ⬆️
Files with missing lines Coverage Δ
internal/querycoordv2/meta/channel_dist_manager.go 90.84% <100.00%> (+90.84%) ⬆️
internal/querycoordv2/task/executor.go 61.67% <ø> (ø)

... and 1278 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 26, 2025

/ci-rerun-ut-go

@chyezh
Copy link
Contributor Author

chyezh commented Nov 26, 2025

/ci-rerun-ut-integration

3 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Nov 26, 2025

/ci-rerun-ut-integration

@chyezh
Copy link
Contributor Author

chyezh commented Nov 26, 2025

/ci-rerun-ut-integration

@chyezh
Copy link
Contributor Author

chyezh commented Nov 26, 2025

/ci-rerun-ut-integration

@mergify mergify bot added the ci-passed label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants