Skip to content

Conversation

@zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Nov 26, 2025

pr: #45875

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 26, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 26, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Nov 26, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #45875 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2025

@zhagnlu cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.60%. Comparing base (cb08db0) to head (5a7dc0b).
⚠️ Report is 294 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/datanode/index/task_stats.go 0.00% 10 Missing ⚠️
internal/querynodev2/segments/segment_loader.go 47.05% 8 Missing and 1 partial ⚠️
internal/util/indexcgowrapper/index.go 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45876      +/-   ##
==========================================
- Coverage   76.99%   76.60%   -0.40%     
==========================================
  Files        1700     1856     +156     
  Lines      262533   287855   +25322     
==========================================
+ Hits       202142   220502   +18360     
- Misses      53550    60000    +6450     
- Partials     6841     7353     +512     
Components Coverage Δ
Client 78.03% <65.76%> (-0.11%) ⬇️
Core 83.66% <79.24%> (+1.45%) ⬆️
Go 74.61% <52.20%> (-0.78%) ⬇️
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 97.61% <100.00%> (-0.13%) ⬇️
internal/querynodev2/segments/segment_loader.go 59.52% <47.05%> (-2.62%) ⬇️
internal/util/indexcgowrapper/index.go 56.83% <0.00%> (-0.90%) ⬇️
internal/datanode/index/task_stats.go 52.69% <0.00%> (-0.78%) ⬇️

... and 655 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhagnlu zhagnlu force-pushed the estimate_jsonstats_2.6 branch from f8e7612 to 5a7dc0b Compare November 27, 2025 03:49
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #45875 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@mergify mergify bot added the ci-passed label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants