Skip to content

Conversation

@anderson-suga
Copy link

PR Checklist

Overview

This PR updates the following dependencies to patch security vulnerabilities:

  • glob: upgraded to ^10.5.0
  • js-yaml: upgraded to ^4.1.1

Motivation

These updates are required to resolve open CVEs found in the previous versions of these packages.

Copy link

@pdeveltere pdeveltere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get this merged asap 🙏🏽 ❤️

@mark-wiemer
Copy link
Member

  • For glob, "Library Safe: The core glob library API (glob(), globSync(), streams/iterators) is not affected", so this isn't necessary.
  • For js-yaml, "All users who parse untrusted yaml documents may be impacted.". Mocha only parses YAML that the user provides to it, so there is no need for us to update.

I appreciate the lookout for security concerns, but unfortunately a lot of alerts are false positives. Please comment in the relevant issue if you think these changes are still necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: mocha's runtime dependency glob is reported as vulnerable by npm audit

4 participants