Skip to content

Commit 2f9ac0e

Browse files
committed
add more comments
1 parent 0843781 commit 2f9ac0e

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

scripts/docker/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# This Dockerfile sets up a Trinity-RFT environment with minimal support.
12
# Build and run the docker image with the following command:
23
#
34
# cd <Trinity-RFT root dir>

scripts/docker/Dockerfile.megatron

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# This Dockerfile sets up a Trinity-RFT environment with Megatron-LM support.
12
# Build and run the docker image with the following command:
23
#
34
# cd <Trinity-RFT root dir>
@@ -36,7 +37,7 @@ RUN pip install --upgrade pip \
3637
--resume-retries 20 git+https://github.com/NVIDIA/apex.git
3738

3839
# Set Env variables
39-
40+
j
4041
# WANDB
4142
# ENV WANDB_API_KEY=
4243
# ENV WANDB_BASE_URL=

scripts/docker/Dockerfile.uv

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1+
# This Dockerfile sets up a Trinity-RFT environment with Megatron support using uv.
12
# Build and run the docker image with the following command:
23
#
34
# cd <Trinity-RFT root dir>
45
# docker build -f scripts/docker/Dockerfile.uv -t trinity-rft:latest .
56
# docker run -it --gpus all --shm-size="64g" --rm -v $PWD:/workspace -v <root_path_of_data_and_checkpoints>:/data trinity-rft:latest
6-
7+
#
8+
# Note:
9+
# 1. This Dockerfile uses 'uv' to create a virtual environment for better package management. If you want a simpler setup without 'uv', please refer to `scripts/docker/Dockerfile`.
10+
# 2. Make sure to use `uv pip` to install packages within the virtual environment.
711

812
FROM nvcr.io/nvidia/cuda:12.8.1-cudnn-devel-ubuntu22.04
913

0 commit comments

Comments
 (0)