Add support for BigInt and 1234n/1234N constants #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgutov
requested changes
Oct 14, 2019
| # History of user-visible changes | ||
|
|
||
| ## 2019-10-14 | ||
| * Added support for BigInt and 1234n or 1234N constants. |
Collaborator
There was a problem hiding this comment.
Please put that under Next
| (js2-add-to-string c) | ||
| (setq c (js2-get-char)) | ||
| while (js2-digit-p c)))) | ||
| ;; BigInt constant (1234n or 1234N) |
Collaborator
There was a problem hiding this comment.
Could you add a test maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BigIntextern and support for 1234n and 1234N constants conditionalized for Harmony (JS language version >= 200).