Skip to content

Conversation

@hihry
Copy link
Contributor

@hihry hihry commented Aug 1, 2025

Description

Addresses #3243

This PR improves the documentation for the composeMultiArrayMessage function in common.cpp within the moveit_servo module.

  • Added a Doxygen-compatible comment block to clarify the function’s purpose, parameters, return value, and usage.
  • Helps developers understand how to use this function when working with controllers that accept std_msgs::msg::Float64MultiArray messages (rather than trajectory_msgs::msg::JointTrajectory).
  • Enhances clarity and aligns with MoveIt 2’s commitment to being an accessible, industry-standard robotics framework.

This change is purely a documentation update and does not affect runtime behavior.

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header file already has the docstrings. Please add it to the one there.

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was just checking this on some downtime since the same issue has come up before. Once an active maintainer approves, you should be all set.

@github-actions
Copy link

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Sep 30, 2025
@github-actions github-actions bot removed the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Oct 13, 2025
@nbbrooks nbbrooks merged commit 760277f into moveit:main Nov 27, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants