Skip to content

Fix parameter passing in generate_state_database.cpp #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix parameter passing in generate_state_database.cpp #3545

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f11bad
Fix parameter passing in generate_state_database.cpp
Aug 7, 2025
e1607a6
Address review: unify types to unsigned int (incl. default_value)
Aug 8, 2025
6de5a4d
Restore original function name
rhaschke Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions moveit_planners/ompl/ompl_interface/scripts/generate_state_database.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ static const std::string ROBOT_DESCRIPTION = "robot_description";

static const std::string CONSTRAINT_PARAMETER = "constraints";

static bool getUintParameterOr(const rclcpp::Node::SharedPtr& node, const std::string& param_name,
size_t&& result_value, const size_t default_value)
static bool get_uint_parameter_or(const rclcpp::Node::SharedPtr& node, const std::string& param_name,
unsigned int& result_value, const size_t default_value)
Copy link
Contributor

@rhaschke rhaschke Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should consistently use size_t or unsigned int:

Suggested change
unsigned int& result_value, const size_t default_value)
unsigned int& result_value, const unsigned int default_value)

Copy link
Author

@XueZhiai123 XueZhiai123 Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! You’re right—I’ll unify all related types in the function signature to unsigned int, including the default value type. I’ll verify everything locally tomorrow and then immediately update the branch and push a new PR. Thank you again for your guidance, and I look forward to any further feedback!

Copy link
Author

@XueZhiai123 XueZhiai123 Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I’ve unified the types to unsigned int (including the default value) and pushed the update. Please take another look.

{
int param_value;
if (node->get_parameter(param_name, param_value))
Expand All @@ -76,6 +76,7 @@ static bool getUintParameterOr(const rclcpp::Node::SharedPtr& node, const std::s
return true;
}


struct GenerateStateDatabaseParameters
{
bool setFromNode(const rclcpp::Node::SharedPtr& node)
Expand Down