Skip to content

Conversation

@hackebrot
Copy link
Contributor

This PR introduces the ability to retrieve all commits included in a given deployment, addressing a key requirement for accurately measuring Lead Time for Changes in Four Keys.

Key Changes

  • Added GitHub REST API integration for comparing commits (with support for paginated responses)
  • Rearchitected GitHub code to enable package consumers to select which API to use for higher level operations
  • Added higher level function for querying deployed commits for a given deployment
  • Introduced structured logging to both the metrics CLI app as well as the github package

Recommended review order

  1. go.mod and go.sum for new github.com/google/go-github/v68 dependency
  2. Files under pkg/github/rest/ with new GitHub REST API code
  3. Files under pkg/github/graphql/ with updated GitHub GraphQL API code
  4. Changes for pkg/github/*.go with higher-level GitHub API code
  5. Files under pkg/github/internal/test/ with test framework for pkg/github
  6. Files under metrics/internal/factory/ for refactored factory code
  7. CLI app changes in metrics/cmd/**/*.go
  8. Remaining files in metrics/

Issues

Resolve #19
Resolve #30
Resolve #33

Notes

Note: AI tools were used in generating this pull request 🤖

@hackebrot hackebrot added feature New feature or request app:metrics Changes related to the metrics CLI app pkg:github Changes related to pkg/github labels Mar 11, 2025
@hackebrot hackebrot force-pushed the query-deployed-commits branch from 9bebbc3 to 7d757a4 Compare March 11, 2025 18:08
@hackebrot hackebrot force-pushed the query-deployed-commits branch from 7d757a4 to dc3bb74 Compare March 11, 2025 18:31
@hackebrot hackebrot closed this Mar 11, 2025
@hackebrot hackebrot deleted the query-deployed-commits branch March 11, 2025 23:58
@hackebrot hackebrot restored the query-deployed-commits branch March 11, 2025 23:59
@hackebrot hackebrot deleted the query-deployed-commits branch March 12, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:metrics Changes related to the metrics CLI app feature New feature or request pkg:github Changes related to pkg/github

Projects

None yet

2 participants