Add @retry to two more places #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push Health, cause we just observed a failure there; and job details cause that seems like it could fail. I always have a vague recollection that the order of decorators matters so I'm going to fix on instance and then put in a script to double check things. Although truthfully I'm not 100% sure it's necessary.
maltejur
approved these changes
Jun 10, 2025
Collaborator
maltejur
left a comment
maltejur
left a comment
There was a problem hiding this comment.
Although truthfully I'm not 100% sure it's necessary.
Seems like a good change to me. logEntryExit would otherwise be inconsistent with logging its things for each function retry or only once for the whole function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push Health, cause we just observed a failure there; and job details cause that seems like it could fail.
I always have a vague recollection that the order of decorators matters so I'm going to fix on instance and then put in a script to double check things. Although truthfully I'm not 100% sure it's necessary.