Skip to content

Conversation

@ChausseBenjamin
Copy link

Fixes this checkhealth issue:

- ⚠️ WARNING vim.lsp.get_buffers_by_client_id() is deprecated. Feature will be removed in Nvim 0.13
  - ADVICE:
    - use vim.lsp.get_client_by_id(id).attached_buffers instead.
    - stack traceback:
        ~/.local/share/nvim/site/pack/core/opt/rustaceanvim/lua/rustaceanvim/server_status.lua:52
        ~/.local/share/bob/nightly/share/nvim/runtime/lua/vim/lsp/client.lua:1194
        ~/.local/share/bob/nightly/share/nvim/runtime/lua/vim/lsp/client.lua:449
        vim/_editor.lua:0

Note that I'm currently on the nightly build of Neovim

Fixes this `checkhealth issue`:
```
- ⚠️ WARNING vim.lsp.get_buffers_by_client_id() is deprecated. Feature will be removed in Nvim 0.13
  - ADVICE:
    - use vim.lsp.get_client_by_id(id).attached_buffers instead.
    - stack traceback:
        ~/.local/share/nvim/site/pack/core/opt/rustaceanvim/lua/rustaceanvim/server_status.lua:52
        ~/.local/share/bob/nightly/share/nvim/runtime/lua/vim/lsp/client.lua:1194
        ~/.local/share/bob/nightly/share/nvim/runtime/lua/vim/lsp/client.lua:449
        vim/_editor.lua:0
```
@github-actions
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏

  • Have you also tested this change in Neovim 0.11?

CI is failing on the lua-ls type checks:

Warning: lua/rustaceanvim/server_status.lua:53:42 [Warning] Cannot assign `true` to `integer?`.
       > - `true` cannot match `integer?`
       > - Type `true` cannot match `nil`
       > - Type `true` cannot match `integer` (assign-type-mismatch)
       >           if vim.lsp.inlay_hint.is_enabled { bufnr = bufnr } then
       >                                              ^^^^^

See https://github.com/mrcjkb/rustaceanvim/blob/master/CONTRIBUTING.md#type-safety

Note

I have a weekly cron job that updates the
Neovim nightly pin and runs CI and fails if there's a new deprecation
(as long as it's annotated with ---@deprecated).
That's when I typically fix nightly deprecation warnings.

@mrcjkb
Copy link
Owner

mrcjkb commented Nov 25, 2025

fe91aad

@mrcjkb mrcjkb closed this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants